-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[skCrypter] add new port #21836
Merged
Merged
[skCrypter] add new port #21836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[skCryper] format vcpkg.json
JonLiu1993
added
the
category:new-port
The issue is requesting a new library to be added; consider making a PR!
label
Dec 6, 2021
JackBoosY
suggested changes
Dec 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error: while loading skcrypter:
The port directory (/agent/_work/1/s/ports/skcrypter) does not exist
Error: failed to load port from /agent/_work/1/s/ports/skcrypte
Please use all lower-case folder ports/skcrypter instead.
updated my bad |
JonLiu1993
approved these changes
Dec 7, 2021
JonLiu1993
added
info:reviewed
Pull Request changes follow basic guidelines
and removed
requires:author-response
labels
Dec 7, 2021
Thanks for the new port! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category:new-port
The issue is requesting a new library to be added; consider making a PR!
info:reviewed
Pull Request changes follow basic guidelines
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
This PR implements the port port for skCrypter: https://github.com/skadro-official/skCrypter header only library
What does your PR fix?
Adds port for skCrypter: https://github.com/skadro-official/skCrypter header only library
Which triplets are supported/not supported? Have you updated the CI baseline?
All windows triplets work fine, as this is just a header all others should works as well but untested.
I haven't updated the CI baseline.
Does your PR follow the maintainer guide?
Yes, as far as I'm aware
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?Yes