Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skCrypter] add new port #21836

Merged
merged 4 commits into from
Dec 7, 2021
Merged

[skCrypter] add new port #21836

merged 4 commits into from
Dec 7, 2021

Conversation

S0PEX
Copy link
Contributor

@S0PEX S0PEX commented Dec 3, 2021

Describe the pull request
This PR implements the port port for skCrypter: https://github.com/skadro-official/skCrypter header only library

  • What does your PR fix?

Adds port for skCrypter: https://github.com/skadro-official/skCrypter header only library

  • Which triplets are supported/not supported? Have you updated the CI baseline?

All windows triplets work fine, as this is just a header all others should works as well but untested.
I haven't updated the CI baseline.

Yes, as far as I'm aware

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

[skCryper] format vcpkg.json
@ghost
Copy link

ghost commented Dec 3, 2021

CLA assistant check
All CLA requirements met.

@JonLiu1993 JonLiu1993 self-assigned this Dec 6, 2021
@JonLiu1993 JonLiu1993 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Dec 6, 2021
Copy link
Contributor

@JackBoosY JackBoosY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error: while loading skcrypter:
The port directory (/agent/_work/1/s/ports/skcrypter) does not exist
Error: failed to load port from /agent/_work/1/s/ports/skcrypte

Please use all lower-case folder ports/skcrypter instead.

@S0PEX
Copy link
Contributor Author

S0PEX commented Dec 6, 2021

updated my bad

@JonLiu1993 JonLiu1993 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Dec 7, 2021
@BillyONeal BillyONeal merged commit 80bd733 into microsoft:master Dec 7, 2021
@BillyONeal
Copy link
Member

Thanks for the new port!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants