[highfive] Add eigen3 feature option #21897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonLiu1993
added
category:port-feature
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 431d3810aa9241aed49b14367be417f225d2af5e -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/h-/highfive.json b/versions/h-/highfive.json
index bebffde..3d98b98 100644
--- a/versions/h-/highfive.json
+++ b/versions/h-/highfive.json
@@ -1,7 +1,7 @@
{
"versions": [
{
- "git-tree": "ccdcfa177fc48552d13cee2a9759d4fb14dbbe3a",
+ "git-tree": "c014dff160e047536190f8ae97b12b33550eda16",
"version": "2.3",
"port-version": 1
},
JackBoosY
suggested changes
Dec 8, 2021
JackBoosY
suggested changes
Dec 9, 2021
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 431d3810aa9241aed49b14367be417f225d2af5e -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/h-/highfive.json b/versions/h-/highfive.json
index 52aaf28..625d311 100644
--- a/versions/h-/highfive.json
+++ b/versions/h-/highfive.json
@@ -1,7 +1,7 @@
{
"versions": [
{
- "git-tree": "3841a549b9308221ed9a5201dadbb6ec1955907e",
+ "git-tree": "d6233178af08a74ff1637956504e2039f51e6a8a",
"version": "2.3",
"port-version": 1
},
JackBoosY
approved these changes
Dec 9, 2021
JackBoosY
added
info:reviewed
BillyONeal
reviewed
Dec 10, 2021
BillyONeal
added
requires:author-response
and removed
info:reviewed
JackBoosY
approved these changes
Dec 10, 2021
JackBoosY
approved these changes
Dec 10, 2021
JackBoosY
added
info:reviewed
|
Thanks for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
Fixes [highfive] Eigen3 feature option #21845Add Eigen3 feature option such that highfive[eigen3] is available.
Execpt feature "test", all features are tested successfully in the following triplet:
feature "test" test successfully in the following triplet:
Tested failed in x64-windows-static triplet, and this error is an old problem that is difficult to solve, the detail error can refer this comment:[vcpkg.cmake] Cleanup every special case in the find_package override #18047 (comment)