Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wtl] Add two "post-release updates". #21924

Merged
merged 2 commits into from
Dec 10, 2021
Merged

[wtl] Add two "post-release updates". #21924

merged 2 commits into from
Dec 10, 2021

Conversation

chrullrich
Copy link
Contributor

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 7bb175eafedb203f19b18cf211666ec728c7461a -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index d91e4e8..3e8525e 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -7270,7 +7270,7 @@
     },
     "wtl": {
       "baseline": "10.0.10320",
-      "port-version": 1
+      "port-version": 2
     },
     "wxchartdir": {
       "baseline": "1.0.0",
diff --git a/versions/w-/wtl.json b/versions/w-/wtl.json
index 394a38e..474f02c 100644
--- a/versions/w-/wtl.json
+++ b/versions/w-/wtl.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "3345336300f47e924a80d3be0f3fb76c558a54fe",
+      "version-string": "10.0.10320",
+      "port-version": 2
+    },
     {
       "git-tree": "6d429012165553d38ea4ae45057ce85bb34deb96",
       "version-string": "10.0.10320",

@chrullrich chrullrich marked this pull request as ready for review December 8, 2021 18:57
@chrullrich
Copy link
Contributor Author

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

As long as this feature is entirely undocumented, I do not think it is particularly helpful, no.

I could not immediately find anything that describes what it does, what it is good for, or even who it is addressed to (i.e. whether I am actually supposed to do what it says), and x-add-version is not in vcpkg's usage message.

@JackBoosY JackBoosY added the category:port-bug The issue is with a library, which is something the port should already support label Dec 9, 2021
Copy link
Contributor

@JackBoosY JackBoosY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run command vcpkg x-add-version --all then commit the changes.

@BillyONeal
Copy link
Member

As long as this feature is entirely undocumented, I do not think it is particularly helpful, no.

FWIW, it did ask you to run the 'magic undocumented command line' in the text but our diagnostics can almost always get better.

@BillyONeal BillyONeal merged commit 34a73b5 into microsoft:master Dec 10, 2021
@BillyONeal
Copy link
Member

Thanks for the patches!

@chrullrich chrullrich deleted the wtl-two-updates branch December 11, 2021 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants