Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minio-cpp] add new port #22242

Merged
merged 14 commits into from
Jan 4, 2022
Merged

[minio-cpp] add new port #22242

merged 14 commits into from
Jan 4, 2022

Conversation

kkzi
Copy link
Contributor

@kkzi kkzi commented Dec 29, 2021

Describe the pull request

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/
Ok

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for minio-cpp but no changes to version or port version.
-- Version: 0.0.1
-- Old SHA: 6a72a9c2db2557a20725ffbe5f42ca2ced191273
-- New SHA: 7d74416b54978684e3e93a8fc3e1a3eab0351e61
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/minio-cpp/portfile.cmake

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/minio-cpp/portfile.cmake

@JonLiu1993 JonLiu1993 self-assigned this Dec 29, 2021
@JonLiu1993 JonLiu1993 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Dec 29, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for minio-cpp but no changes to version or port version.
-- Version: 0.0.1
-- Old SHA: 7d74416b54978684e3e93a8fc3e1a3eab0351e61
-- New SHA: 7bc2b0d04c8a8422d182bba9463691199e31ce8a
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

@JonLiu1993
Copy link
Member

@kkzi ,Thanks for your pr, please run command "./vcpkg x-add-version minio-cpp --overwrite-version" and commit again

it looks the post build step failed,
See the CI failures:

CMake Error at cmake_install.cmake:54 (file):
  file cannot create directory: /pkgconfig.  Maybe need administrative
  privileges.

@kkzi
Copy link
Contributor Author

kkzi commented Dec 30, 2021

@kkzi ,Thanks for your pr, please run command "./vcpkg x-add-version minio-cpp --overwrite-version" and commit again

it looks the post build step failed, See the CI failures:

CMake Error at cmake_install.cmake:54 (file):
  file cannot create directory: /pkgconfig.  Maybe need administrative
  privileges.

Could you please help me heck this error log ?

2021-12-29T14:06:21.0914520Z Starting package 8/8: minio-cpp:x64-linux
2021-12-29T14:06:21.0915146Z Building package minio-cpp[core]:x64-linux...
2021-12-29T14:06:21.1071905Z -- Downloading https://github.com/minio/minio-cpp/archive/0847e56f31e13d32c924029d5ffaa865f8396462.tar.gz -> minio-minio-cpp-0847e56f31e13d32c924029d5ffaa865f8396462.tar.gz...
2021-12-29T14:06:21.8637855Z -- Extracting source /mnt/vcpkg-ci/downloads/minio-minio-cpp-0847e56f31e13d32c924029d5ffaa865f8396462.tar.gz
2021-12-29T14:06:21.8845625Z -- Using source at /mnt/vcpkg-ci/buildtrees/minio-cpp/src/65f8396462-29483391f8.clean
2021-12-29T14:06:21.8853887Z -- Configuring x64-linux-dbg
2021-12-29T14:06:22.7267268Z -- Configuring x64-linux-rel
2021-12-29T14:06:23.5683213Z -- Building x64-linux-dbg
2021-12-29T14:06:24.6156627Z CMake Error at scripts/cmake/vcpkg_execute_build_process.cmake:155 (message):
2021-12-29T14:06:24.6158902Z Command failed: /mnt/vcpkg-ci/downloads/tools/cmake-3.21.1-linux/cmake-3.21.1-linux-x86_64/bin/cmake --build . --config Debug --target install -- -v -j33
2021-12-29T14:06:24.6160328Z Working Directory: /mnt/vcpkg-ci/buildtrees/minio-cpp/x64-linux-dbg
2021-12-29T14:06:24.6161308Z See logs for more information:
2021-12-29T14:06:24.6162230Z /mnt/vcpkg-ci/buildtrees/minio-cpp/install-x64-linux-dbg-out.log
2021-12-29T14:06:24.6163332Z /mnt/vcpkg-ci/buildtrees/minio-cpp/install-x64-linux-dbg-err.log
2021-12-29T14:06:24.6163816Z
2021-12-29T14:06:24.6164337Z Call Stack (most recent call first):
2021-12-29T14:06:24.6165361Z /mnt/vcpkg-ci/installed/x64-linux/share/vcpkg-cmake/vcpkg_cmake_build.cmake:102 (vcpkg_execute_build_process)
2021-12-29T14:06:24.6166248Z /mnt/vcpkg-ci/installed/x64-linux/share/vcpkg-cmake/vcpkg_cmake_install.cmake:41 (vcpkg_cmake_build)
2021-12-29T14:06:24.6166970Z ports/minio-cpp/portfile.cmake:15 (vcpkg_cmake_install)
2021-12-29T14:06:24.6167375Z scripts/ports.cmake:142 (include)

@JonLiu1993
Copy link
Member

@kkzi ,

In https://github.com/minio/minio-cpp/blob/0847e56f31e13d32c924029d5ffaa865f8396462/CMakeLists.txt#L118:

install(FILES ${CMAKE_BINARY_DIR}/miniocpp.pc DESTINATION ${CMAKE_INSTALL_DATAROOTDIR}/pkgconfig)

The CMAKE_INSTALL_DATAROOTDIR is empty and you should add -DCMAKE_INSTALL_DATAROOTDIR=DIR to vcpkg_configure_cmake.

ports/minio-cpp/portfile.cmake Outdated Show resolved Hide resolved
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for minio-cpp but no changes to version or port version.
-- Version: 0.0.1
-- Old SHA: 7bc2b0d04c8a8422d182bba9463691199e31ce8a
-- New SHA: 57f8cd7ed90f516be64a43fb4f16276d2eb8a7b7
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

@kkzi kkzi marked this pull request as ready for review December 31, 2021 03:05
scripts/ci.baseline.txt Outdated Show resolved Hide resolved
ports/minio-cpp/fix_cmake_file.patch Outdated Show resolved Hide resolved
@JonLiu1993 JonLiu1993 changed the title [new port] minio-cpp v0.0.1 [minio-cpp] add new port Dec 31, 2021
@JonLiu1993 JonLiu1993 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jan 4, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for minio-cpp but no changes to version or port version.
-- Version: 0.0.1
-- Old SHA: a71471fab2c087924710f6d2170bcaab508df674
-- New SHA: fc5b849641d2df439ce575563840c819860a5221
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

@strega-nil-ms
Copy link
Contributor

This needed some changes, so I made them; merging as soon as this finishes running.

@strega-nil-ms strega-nil-ms merged commit 044f9b8 into microsoft:master Jan 4, 2022
@strega-nil-ms
Copy link
Contributor

Thanks @kkzi!

Jimmy-Hu added a commit to Jimmy-Hu/vcpkg that referenced this pull request Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Port Request] minio-cpp
4 participants