Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[serdepp] add new port #22455

Merged
merged 30 commits into from
Mar 4, 2022
Merged

[serdepp] add new port #22455

merged 30 commits into from
Mar 4, 2022

Conversation

injae
Copy link
Contributor

@injae injae commented Jan 10, 2022

Describe the pull request

  • What does your PR fix?

    Adds a serdepp port

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    all, No

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

@ghost
Copy link

ghost commented Jan 10, 2022

CLA assistant check
All CLA requirements met.

@injae injae marked this pull request as draft January 10, 2022 08:34
@injae
Copy link
Contributor Author

injae commented Jan 10, 2022

It doesn't seem to find the files installed with ExternalProject_add.

x64_linux error.log

CMake Error at cmake/cppm_loader.cmake:30 (include):
  include could not find requested file:

    /Users/vagrant/.cppm/cmake/cppm-loader/load.cmake
Call Stack (most recent call first):
  CMakeLists.txt:4 (include)


CMake Error at CMakeLists.txt:5 (cppm_project):
  Unknown CMake command "cppm_project".

cppm-loader/load.cmake

if(CMAKE_SYSTEM_NAME STREQUAL "Windows" OR (NOT CMAKE_SYSTEM_NAME AND CMAKE_HOST_SYSTEM_NAME STREQUAL "Windows"))
    set(env_home "$ENV{USERPROFILE}")
else()
    set(env_home "$ENV{HOME}")
endif()
string(REPLACE "\\" "/" HOME "${env_home}")

set(CPPM_ROOT          ${HOME}/.cppm)
set(CPPM_LOADER_CACHE  ${CPPM_ROOT}/cache/cppm-loader/git)
set(CPPM_LOADER_PATH   ${CPPM_ROOT}/cmake/cppm-loader)

if(NOT DEFINED IS_CPPM_LOADER_LOADED)
set(_install_script "${CPPM_LOADER_CACHE}/install-script")
file(WRITE ${_install_script}/CMakeLists.txt
"cmake_minimum_required(VERSION 3.6)
project(CPPM_LOADER_DOWNLOAD NONE)
include(ExternalProject)
ExternalProject_Add(cppm-loader
    GIT_REPOSITORY https://github.com/injae/cppm-loader.git
    SOURCE_DIR ${CPPM_LOADER_PATH}
    BINARY_DIR ${CPPM_LOADER_CACHE}/build
    CONFIGURE_COMMAND \"\"
    BUILD_COMMAND  \"\"
    INSTALL_COMMAND \"\"
)"
)
execute_process(COMMAND cmake . WORKING_DIRECTORY ${_install_script} OUTPUT_QUIET)
execute_process(COMMAND cmake  --build . WORKING_DIRECTORY ${_install_script} OUTPUT_QUIET)
endif()
include(${CPPM_LOADER_PATH}/load.cmake)

@JonLiu1993 JonLiu1993 self-assigned this Jan 10, 2022
@JonLiu1993 JonLiu1993 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Jan 10, 2022
@JonLiu1993
Copy link
Member

@injae
Copy link
Contributor Author

injae commented Jan 11, 2022

ExternalProject_Add does not seem to work because of the problem that find_package(GIT) does not work in portfile.cmake.

error: could not find git for clone of cppm-loader
Call Stack (most recent call first):
  D:/downloads/tools/cmake-3.21.1-windows/cmake-3.21.1-windows-i386/share/cmake-3.21/Modules/ExternalProject.cmake:3700 (_ep_add_download_command)
  CMakeLists.txt:4 (ExternalProject_Add)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/serdepp/vcpkg.json

Valid values for the license field can be found in the documentation

@injae injae marked this pull request as ready for review March 2, 2022 06:12
ports/serdepp/vcpkg.json Outdated Show resolved Hide resolved
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Mar 4, 2022
@vicroms vicroms merged commit ce25440 into microsoft:master Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants