Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sdl1] no absolute paths #22718

Merged
merged 1 commit into from
Jan 24, 2022
Merged

[sdl1] no absolute paths #22718

merged 1 commit into from
Jan 24, 2022

Conversation

autoantwort
Copy link
Contributor

For #20469

github-actions[bot]
github-actions bot approved these changes Jan 23, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/sdl1/vcpkg.json

Valid values for the license field are listed at https://spdx.org/licenses/

@JonLiu1993 JonLiu1993 self-assigned this Jan 24, 2022
@JonLiu1993 JonLiu1993 added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:port-bug The issue is with a library, which is something the port should already support and removed category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist labels Jan 24, 2022
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Jan 24, 2022
@ras0219-msft ras0219-msft merged commit 8ce7e2a into microsoft:master Jan 24, 2022
@ras0219-msft
Copy link
Contributor

This LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@JonLiu1993 JonLiu1993 JonLiu1993 approved these changes

Assignees

@JonLiu1993 JonLiu1993

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@autoantwort @ras0219-msft @JonLiu1993