Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[benchmark] Remove vcpkg_fail_port_install. #22728

Merged

Conversation

BillyONeal
Copy link
Member

A comment was moved from portfile.cmake to vcpkg.json.

In support of #21502

A comment was moved from portfile.cmake to vcpkg.json.

In support of microsoft#21502
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/benchmark/vcpkg.json

Valid values for the license field are listed at https://spdx.org/licenses/

@BillyONeal
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@BillyONeal BillyONeal added the info:internal This PR or Issue was filed by the vcpkg team. label Jan 24, 2022
@strega-nil-ms
Copy link
Contributor

Thanks!

@strega-nil-ms strega-nil-ms merged commit b3755cb into microsoft:master Jan 24, 2022
strega-nil-ms pushed a commit to BillyONeal/vcpkg that referenced this pull request Jan 24, 2022
@BillyONeal BillyONeal deleted the remove_fail_port_install_benchmark branch January 25, 2022 00:59
@JonLiu1993 JonLiu1993 added the category:port-bug The issue is with a library, which is something the port should already support label Jan 25, 2022
strega-nil-ms pushed a commit that referenced this pull request Jan 25, 2022
* Bulk remove vcpkg_fail_port_install calls.

Interesting ones have been split out into separate reviews, where "interesting" means "anything more than just deleting the call to vcpkg_fail_port_install",

In support of #21502

* Update version database.

* Revert google benchmark changes already submitted as #22728

* Repair version database.
BillyONeal added a commit to BillyONeal/vcpkg that referenced this pull request Jan 27, 2022
A comment was moved from portfile.cmake to vcpkg.json.

In support of microsoft#21502
BillyONeal added a commit that referenced this pull request Jan 27, 2022
A comment was moved from portfile.cmake to vcpkg.json.

In support of #21502
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants