Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libtins] Fix usage #22820

Merged
merged 2 commits into from
Jan 31, 2022
Merged

[libtins] Fix usage #22820

merged 2 commits into from
Jan 31, 2022

Conversation

JackBoosY
Copy link
Contributor

Fix definiton TINS_API value.

#if defined(_WIN32) && !defined(TINS_STATIC)
    // Export/import symbols, depending on whether we're compiling or consuming the lib
    #ifdef tins_EXPORTS
        #define TINS_API __declspec(dllexport)
    #else
        #define TINS_API __declspec(dllimport)
    #endif // tins_EXPORTS
#else 
    // Otherwise, default this to an empty macro
    #define TINS_API
#endif // _WIN32 && !TINS_STATIC

Fixes #11904.

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Jan 27, 2022
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Jan 29, 2022
@ras0219-msft ras0219-msft merged commit ec79067 into microsoft:master Jan 31, 2022
@ras0219-msft
Copy link
Contributor

LGTM, thanks!

@JackBoosY JackBoosY deleted the dev/jack/11904 branch February 5, 2022 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LibTins cannot be statically linked because it using __declspec(dllimport)
3 participants