[jasper]: Move opengl & freeglut dependencies under default-features in order to enable flexibility to not require any of those when importing jasper package (via default-features=false). #22895
Conversation
…in order to enable flexibility to not require any of those when importing jasper package (via default-features=false).
…in order to enable flexibility to not require any of those when importing jasper package (via default-features=false).
|
|
|
Some invalid commit noise re: [x264] cause I improperly reused this branch for a different PR :( |
strega-nil-ms
added
category:port-feature
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/jasper/vcpkg.json
Valid values for the license field are listed at https://spdx.org/licenses/
Co-authored-by: nicole mazzuca <[email protected]>
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/jasper/vcpkg.json
Valid values for the license field are listed at https://spdx.org/licenses/
LilyWangLL
added
info:reviewed
|
Ok, this LGTM then. Thanks! |
Describe the pull request
[jasper]: Move opengl & freeglut dependencies under default-features in order to enable flexibility to not require any of those when importing jasper package (via default-features=false).
What does your PR fix?
Fixes # Allow developer to not require opengl and/or freeglut package in order to be able to import jasper package. Hopefully this should be fully backward compatible and transparent to current users. Useful for developers that cross-compile on systems that do not have opengl.
Which triplets are supported/not supported? Have you updated the [CI baseline]
(https://github.com/microsoft/vcpkg/blob/master/scripts/ci.baseline.txt)?
Unchanged from previous port. Not sure about expected syntax below.
<linux, windows, uwp>,
,
Does your PR follow the maintainer guide?
Careful review is advisable since it is my 1st PR (ever).
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/
I believe it is complete as is, but really not certain about CI requirements.