-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Folly, fizz, wangle, proxygen, fbthrift, mvfst] Update to latest version #22967
Conversation
rsocket fails with error:
Edit: fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/fbthrift/vcpkg.json
ports/fizz/vcpkg.json
ports/mvfst/vcpkg.json
ports/proxygen/vcpkg.json
ports/rsocket/vcpkg.json
Valid values for the license field are listed at https://spdx.org/licenses/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/fbthrift/vcpkg.json
ports/fizz/vcpkg.json
ports/mvfst/vcpkg.json
ports/proxygen/vcpkg.json
ports/rsocket/vcpkg.json
Valid values for the license field are listed at https://spdx.org/licenses/
I have tested all features on my local machine |
This LGTM, thanks for the major updates! |
Describe the pull request
I updated these ports in a single PR because wangle depends on fizz and fizz depends on folly.
I needed to fix rsocket as well because of an error (see bellow).
What does your PR fix?
Makes these ports compatible with OpenSSL 3 (see [openssl] update to 3.0.2 #22878 (comment))
Fixes [folly] update to v2021.10.04.00 #20558
Fixes [wangle:x64-linux] build failure #20586
Adds quotes
Remove deprecated cmake
Which triplets are supported/not supported? Have you updated the CI baseline?
Didn't change
Does your PR follow the maintainer guide?
yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?yes
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/