Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hunspell] Add Windows ARM64 Support #22979

Merged
merged 3 commits into from
Feb 7, 2022
Merged

[Hunspell] Add Windows ARM64 Support #22979

merged 3 commits into from
Feb 7, 2022

Conversation

ZacWalk
Copy link
Member

@ZacWalk ZacWalk commented Feb 7, 2022

Describe the pull request

  • What does your PR fix?

    Adds Windows ARM64 Support

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    Added arm64-windows and arm64-windows-static, No (I did not see arm64-windows marked as fail)

  • Does your PR follow the maintainer guide?

    Your answer

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for hunspell but no changes to version or port version.
-- Version: 1.7.0#7
-- Old SHA: a7db92584496fe08ac10f8f32556ca89e14018aa
-- New SHA: acbcd068664bed1cdf8e71999b7ccc5f894b9671
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/hunspell/vcpkg.json

Valid values for the license field are listed at https://spdx.org/licenses/

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 7e7dad5fe20cdc085731343e0e197a7ae655555b -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/h-/hunspell.json b/versions/h-/hunspell.json
index f087930..7477d31 100644
--- a/versions/h-/hunspell.json
+++ b/versions/h-/hunspell.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "acbcd068664bed1cdf8e71999b7ccc5f894b9671",
+      "git-tree": "9beac8cd192fb54839925b083fa72e611d7bcfee",
       "version": "1.7.0",
       "port-version": 8
     },

You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/hunspell/vcpkg.json

Valid values for the license field are listed at https://spdx.org/licenses/

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/hunspell/vcpkg.json

Valid values for the license field are listed at https://spdx.org/licenses/

@ZacWalk ZacWalk marked this pull request as ready for review February 7, 2022 19:31
@BillyONeal BillyONeal merged commit d2b2289 into microsoft:master Feb 7, 2022
Jimmy-Hu added a commit to Jimmy-Hu/vcpkg that referenced this pull request Feb 7, 2022
[Hunspell] Add Windows ARM64 Support (microsoft#22979)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants