-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pcl] Re-fix feature visualization, fix use qhull #22995
[pcl] Re-fix feature visualization, fix use qhull #22995
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout afb2279ad78a7c29b5293d989b9a1a2ca00000cf -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index 942eb08..c099d8b 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -5238,7 +5238,7 @@
},
"pcl": {
"baseline": "1.12.0",
- "port-version": 3
+ "port-version": 4
},
"pcre": {
"baseline": "8.45",
diff --git a/versions/p-/pcl.json b/versions/p-/pcl.json
index d345753..ec94f23 100644
--- a/versions/p-/pcl.json
+++ b/versions/p-/pcl.json
@@ -1,5 +1,10 @@
{
"versions": [
+ {
+ "git-tree": "3eb44f07f0155cf97aa0f3526606e0c7009466a3",
+ "version": "1.12.0",
+ "port-version": 4
+ },
{
"git-tree": "0f0c24ef83692fbcc9434ec9622592ba9b16e0d5",
"version": "1.12.0",
You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/pcl/vcpkg.json
Valid values for the license field are listed at https://spdx.org/licenses/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/pcl/vcpkg.json
Valid values for the license field are listed at https://spdx.org/licenses/
apps BUILD_apps_cloud_composer | ||
apps BUILD_apps_modeler | ||
apps BUILD_apps_point_cloud_editor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These 3 options are not exist.
LGTM, thanks! |
[pcl] Re-fix feature visualization, fix use qhull (microsoft#22995)
visualization
needs setWITH_VTK
toON
first, so change valueWITH_VTK
's key tovisualization
, details please see [pcl] Add feature apps, visualization, simulation, examples and add usage #21788 (comment).HAVE_QHULL
will be used in pcl_config.h:Fixes #17662.