[sqlite3] Add more features #23009
Merged
[sqlite3] Add more features #23009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackBoosY
added
category:port-feature
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
@gmilletAVS Can you please test this PR? Thanks. |
added 2 commits
February 9, 2022 01:10
JackBoosY
commented
Feb 9, 2022
| else() | ||
| message(FATAL_ERROR "Unsupported platform: ${CMAKE_SYSTEM_NAME}") | ||
| endif() | ||
| else() | ||
| set(API "-DSQLITE_API=extern") |
There was a problem hiding this comment.
Reason:
F:\vcpkg\buildtrees\sqlite3\src\3370100-a1573e1602.clean\sqlite3.c(172381): error C2159: more than one storage class specified
F:\vcpkg\buildtrees\sqlite3\src\3370100-a1573e1602.clean\sqlite3.c(214917): error C2159: more than one storage class specified
Souce code:
#ifdef SQLITE_DEBUG
SQLITE_API extern int sqlite3_fts5_may_be_corrupt;
# define assert_nc(x) assert(sqlite3_fts5_may_be_corrupt || (x))
#else
# define assert_nc(x) assert(x)
#endif
JackBoosY
added
the
category:tool-update
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/libspatialite/vcpkg.jsonports/vcpkg-pkgconfig-get-modules/vcpkg.json
Valid values for the license field are listed at https://spdx.org/licenses/
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/libspatialite/vcpkg.jsonports/vcpkg-pkgconfig-get-modules/vcpkg.json
Valid values for the license field are listed at https://spdx.org/licenses/
JackBoosY
added
the
depends:different-pr
This was referenced Feb 11, 2022
LilyWangLL
approved these changes
Feb 14, 2022
JackBoosY
added
info:reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the official features according to the official configure:
Add system macro
SQLITE_OS_WINandSQLITE_OS_UNIX.Fixes #23000.