-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ao] Add new port libao #23031
[ao] Add new port libao #23031
Conversation
Please run command |
Co-authored-by: LilyWangLL <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/ao/vcpkg.json
Valid values for the license field can be found in the documentation
There are error on Linux:
Could you please fix this error? |
I do not intended it run in linux , can I just disabled the linux build |
Ao build failed on UWP with the following error:
|
Co-authored-by: LilyWangLL <[email protected]>
what about just disable it with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Under normal circumstances we would not accept new libraries with such short names, however due to libao
's maturity and renown I believe it is acceptable to use libao
in this case.
normally ,when will this be merge? |
can not be searched in the following website |
Describe the pull request
#21791
What does your PR fix?
add libao port
Which triplets are supported/not supported? Have you updated the CI baseline?
windows,
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?Yes
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/