-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[easyhook] Update target .NET Framework version to 4.7.2. #23040
Conversation
This is the .NET Framework version for VS2017, and is accepted by VS2019 and VS2022. See https://docs.microsoft.com/en-us/dotnet/framework/install/guide-for-developers VS2022 does not support targeting 4.0 Client Profile, so this is necessary to un-break easyhook on VS2022.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/easyhook/vcpkg.json
Valid values for the license field can be found in the documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/easyhook/vcpkg.json
Valid values for the license field can be found in the documentation
* master: (54 commits) [imgui] Update to 1.87 [implot] Update to 0.13 (microsoft#22988) [nu-book-zxing-cpp] New port (microsoft#22657) [librabbitmq] Update to 0.11.0 (microsoft#23037) [doc] Add doc for `supports` expression `staticcrt` (microsoft#23079) [doctest] Update to 2.4.8 (microsoft#23081) [log4cplus] Remove unneeded catch dependency (microsoft#23066) [Azure SDK] Update vcpkg ports for Feb Release (microsoft#23080) [Freerdp] Update to 2.5.0 (microsoft#23095) Update vcpkg-tool to 2022-02-11 (microsoft#23059) Minor bugfixes to MacOS deployment readme. (microsoft#23062) [ci.baseline.txt] Skip colmap on osx due to metis conflict (microsoft#23047) [gtkmm] update to 4.6.0 (microsoft#23024) [faiss] Update to 1.7.2 (microsoft#22705) [ocilib] Disable warning C4191 (microsoft#23028) [polyhook2] Update to latest (microsoft#23044) Add notice about how to export unofficial CMake targets. (microsoft#23041) [Spirv reflect] Add new port (microsoft#22295) [easyhook] Update target .NET Framework version to 4.7.2. (microsoft#23040) [gh suggestions] change license link, make it details (microsoft#22946) [field3d] Remove port (microsoft#22463) ...
This is the .NET Framework version for VS2017, and is accepted by VS2019 and VS2022. See https://docs.microsoft.com/en-us/dotnet/framework/install/guide-for-developers
VS2022 does not support targeting 4.0 Client Profile, so this is necessary to un-break easyhook on VS2022.