Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[leveldb] Fix target "Threads::Threads" was not found #23126

Merged
merged 6 commits into from
Feb 18, 2022

Conversation

LilyWangLL
Copy link
Contributor

Fixes #23099
Fix error:

1> [CMake] CMake Error at /Users/xyz/vcpkg/scripts/buildsystems/vcpkg.cmake:558 (_add_executable):
1> [CMake]   Target "testleveldb" links to target "Threads::Threads" but the target was
1> [CMake]   not found.  Perhaps a find_package() call is missing for an IMPORTED
1> [CMake]   target, or an ALIAS target is missing?

@LilyWangLL LilyWangLL added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Feb 16, 2022
@LilyWangLL LilyWangLL changed the title Dev/lily wang/issue23099 [leveldb] Fix target "Threads::Threads" was not found Feb 16, 2022
@JackBoosY
Copy link
Contributor

JackBoosY commented Feb 16, 2022

Sorry for the typo, I always make this mistake.

@JackBoosY JackBoosY marked this pull request as ready for review February 16, 2022 09:21
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Feb 16, 2022
ports/leveldb/vcpkg.json Outdated Show resolved Hide resolved
@vicroms vicroms closed this Feb 17, 2022
@vicroms vicroms reopened this Feb 17, 2022
@vicroms
Copy link
Member

vicroms commented Feb 17, 2022

Closing and re-opening to hopefully whack clabot awake

@vicroms vicroms closed this Feb 17, 2022
@vicroms vicroms reopened this Feb 17, 2022
@vicroms vicroms merged commit 3ab5fc5 into microsoft:master Feb 18, 2022
@LilyWangLL LilyWangLL deleted the dev/LilyWang/issue23099 branch May 17, 2022 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[leveldb] build failure
4 participants