Change minimum CMake version to 3.7.2. #23134
Conversation
This moves our oldest supported Linux back up to today minus 5 years, Debian 9 from 2017 comes with 3.7.2.
BillyONeal
added
category:documentation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/faad2/vcpkg.json
Valid values for the license field can be found in the documentation
scripts/buildsystems/vcpkg.cmake
Outdated
| if(CMAKE_VERSION VERSION_LESS Z_VCPKG_CMAKE_REQUIRED_MINIMUM_VERSION) | ||
| message(FATAL_ERROR "vcpkg.cmake requires at least CMake ${Z_VCPKG_CMAKE_REQUIRED_MINIMUM_VERSION}.") | ||
| endif() | ||
| # this policy is required for this file; thus, CMake 3.1 is required. | ||
| # this policy is required for this file; thus, CMake 3.7.2 is required. |
There was a problem hiding this comment.
CMP0054 came with CMake 3.1 so it doesn't require 3.7.2
There was a problem hiding this comment.
Good point. I think I should strip the whole comment?
There was a problem hiding this comment.
Yes.
Maybe the lines before and after can be reduced to:
cmake_policy(VERSION 3.7.2)
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/faad2/vcpkg.json
Valid values for the license field can be found in the documentation
* set(CMAKE_TRY_COMPILE_TARGET_TYPE STATIC_LIBRARY) when linking arm64ec static to workaround softintrin as explained in the comment. * Switch to using the _INIT versions of flags now that we require CMake >= 3.7 (as of microsoft#23134 )
|
cc @Neumann-A |
| cmake_policy(PUSH) | ||
| cmake_policy(SET CMP0054 NEW) | ||
| cmake_policy(VERSION 3.7.2) |
There was a problem hiding this comment.
Now I would even suggest cmake_policy(VERSION ${Z_VCPKG_CMAKE_REQUIRED_MINIMUM_VERSION}).
Change minimum CMake version to 3.7.2. (microsoft#23134)
This moves our oldest supported Linux back up to today minus 5 years, Debian 9 from 2017 comes with 3.7.2.
See #19048