Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aws] Support building AWS packages on ARM Linux #23278

Merged
merged 1 commit into from
Feb 28, 2022

Conversation

csw
Copy link
Contributor

@csw csw commented Feb 25, 2022

This adds support for building the AWS packages on Linux on ARM. (Tested with the arm64-linux triplet.) In particular, this allows using them in native Docker containers on Macs with Apple Silicon. These ports previously had the platform constraint !arm & !uwp, presumably because they wouldn't build on Windows on ARM, but this prevented them from being built on Linux on ARM as well. This is only a change to those platform constraints; the packages build successfully, and the subset that I've tested work normally.

  • What does your PR fix?

    Fixes incompatibility with Linux on ARM.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    No changes to supported triplets, adds support for arm-linux and arm64-linux. These are not part of CI, so I haven't changed the CI baseline.

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/aws-c-auth/vcpkg.json
  • ports/aws-c-cal/vcpkg.json
  • ports/aws-c-common/vcpkg.json
  • ports/aws-c-compression/vcpkg.json
  • ports/aws-c-event-stream/vcpkg.json
  • ports/aws-c-http/vcpkg.json
  • ports/aws-c-io/vcpkg.json
  • ports/aws-c-mqtt/vcpkg.json
  • ports/aws-c-s3/vcpkg.json
  • ports/aws-checksums/vcpkg.json
  • ports/aws-crt-cpp/vcpkg.json
  • ports/aws-sdk-cpp/vcpkg.json

Valid values for the license field can be found in the documentation

@LilyWangLL LilyWangLL added the category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. label Feb 28, 2022
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Feb 28, 2022
@vicroms vicroms merged commit 3ad158e into microsoft:master Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants