-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[directxmath, directxtex, directxmesh, directxtk, directxtk12, uvatlas] ports updated #23332
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one portfile where deprecated functions are used.
If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake
-> vcpkg_cmake_install
(from port vcpkg-cmake
)
vcpkg_build_cmake
-> vcpkg_cmake_build
(from port vcpkg-cmake
)
vcpkg_configure_cmake
-> vcpkg_cmake_configure
(Please remove the option PREFER_NINJA
) (from port vcpkg-cmake
)
vcpkg_fixup_cmake_targets
-> vcpkg_cmake_config_fixup
(from port vcpkg-cmake-config
)
In the ports that use the new function, you have to add the corresponding dependencies:
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}
The following files are affected:
ports/directxmath/portfile.cmake
/azp run |
Commenter does not have sufficient privileges for PR 23332 in repo microsoft/vcpkg |
@NancyLi1013 I don't know why some of the test failed, but I think it just needs to be rekicked. I can't do it myself. Can you take a look? |
Verified all supported triplets build locally.
|
…s] ports updated to February 2022 release
I don't understand the failures here. I tried rebasing to latest and they are still happening. They look like infrastructure problems from the logs:
|
It's a known issue about CI, we are fixing it. |
Updating ports to support latest February 2022 GitHub releases of these libraries. Also updated for the fact that all these repos have had the master-to-main rename of their primary branch.