Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[directxmath, directxtex, directxmesh, directxtk, directxtk12, uvatlas] ports updated #23332

Merged
merged 8 commits into from
Mar 2, 2022

Conversation

walbourn
Copy link
Member

@walbourn walbourn commented Mar 1, 2022

Updating ports to support latest February 2022 GitHub releases of these libraries. Also updated for the fact that all these repos have had the master-to-main rename of their primary branch.

Changed to use version-date instead of version-string per request. directxmath port updated to no longer use deprecated VCPKG functions.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/directxmath/portfile.cmake

@walbourn
Copy link
Member Author

walbourn commented Mar 1, 2022

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 23332 in repo microsoft/vcpkg

@walbourn
Copy link
Member Author

walbourn commented Mar 1, 2022

@NancyLi1013 I don't know why some of the test failed, but I think it just needs to be rekicked. I can't do it myself. Can you take a look?

@walbourn
Copy link
Member Author

walbourn commented Mar 2, 2022

Verified all supported triplets build locally.

vcpkg install directxmath:x86-windows
vcpkg install directxmath:x86-windows-static
vcpkg install directxmath:x64-windows
vcpkg install directxmath:x64-windows-static
vcpkg install directxmath:arm64-windows
vcpkg install directxmath:arm64-windows-static
vcpkg install directxmath:x86-uwp
vcpkg install directxmath:x64-uwp
vcpkg install directxmath:arm-uwp
vcpkg install directxmath:arm64-uwp
vcpkg install directxmath:x64-linux
vcpkg install directxmath:arm64-linux

vcpkg install directxtk:x86-windows
vcpkg install directxtk[xaudio2redist]:x86-windows --recurse
vcpkg install directxtk[xaudio2-9]:x86-windows --recurse
vcpkg install directxtk[xaudio2-8]:x86-windows --recurse
vcpkg install directxtk:x86-windows-static
vcpkg install directxtk:x64-windows
vcpkg install directxtk[xaudio2redist]:x64-windows --recurse
vcpkg install directxtk[xaudio2-9]:x64-windows --recurse
vcpkg install directxtk[xaudio2-8]:x64-windows --recurse
vcpkg install directxtk:x64-windows-static
vcpkg install directxtk:arm64-windows
vcpkg install directxtk:arm64-windows-static
vcpkg install directxtk:x86-uwp
vcpkg install directxtk:x64-uwp
vcpkg install directxtk:arm-uwp
vcpkg install directxtk:arm64-uwp

vcpkg install directxtk12:x86-windows
vcpkg install directxtk12:x86-windows-static
vcpkg install directxtk12:x64-windows
vcpkg install directxtk12:x64-windows-static
vcpkg install directxtk12:arm64-windows
vcpkg install directxtk12:arm64-windows-static
vcpkg install directxtk12:x86-uwp
vcpkg install directxtk12:x64-uwp
vcpkg install directxtk12:arm-uwp
vcpkg install directxtk12:arm64-uwp

vcpkg install directxtex:x86-windows
vcpkg install directxtex[openexr]:x86-windows --recurse
vcpkg install directxtex[dx12]:x86-windows --recurse
vcpkg install directxtex:x86-windows-static
vcpkg install directxtex:x64-windows
vcpkg install directxtex[openexr]:x64-windows --recurse
vcpkg install directxtex[dx12]:x64-windows --recurse
vcpkg install directxtex:x64-windows-static
vcpkg install directxtex:arm64-windows
vcpkg install directxtex:arm64-windows-static
vcpkg install directxtex:x86-uwp
vcpkg install directxtex:x64-uwp
vcpkg install directxtex:arm-uwp
vcpkg install directxtex:arm64-uwp
vcpkg install directxtex:x64-linux
vcpkg install directxtex[openexr]:x64-linux --recurse
vcpkg install directxtex:arm64-linux
vcpkg install directxtex[openexr]:arm64-linux --recurse

vcpkg install directxmesh:x86-windows
vcpkg install directxmesh[dx12]:x86-windows --recurse
vcpkg install directxmesh:x86-windows-static
vcpkg install directxmesh:x64-windows
vcpkg install directxmesh[dx12]:x64-windows --recurse
vcpkg install directxmesh:x64-windows-static
vcpkg install directxmesh:arm64-windows
vcpkg install directxmesh:arm64-windows-static
vcpkg install directxmesh:x86-uwp
vcpkg install directxmesh:x64-uwp
vcpkg install directxmesh:arm-uwp
vcpkg install directxmesh:arm64-uwp
vcpkg install directxmesh:x64-linux
vcpkg install directxmesh:arm64-linux

vcpkg install uvatlas:x86-windows
vcpkg install uvatlas[eigen]:x86-windows --recurse
vcpkg install uvatlas:x86-windows-static
vcpkg install uvatlas:x64-windows
vcpkg install uvatlas[eigen]:x64-windows --recurse
vcpkg install uvatlas:x64-windows-static
vcpkg install uvatlas:arm64-windows
vcpkg install uvatlas:arm64-windows-static
vcpkg install uvatlas:x86-uwp
vcpkg install uvatlas:x64-uwp
vcpkg install uvatlas:arm-uwp
vcpkg install uvatlas:arm64-uwp
vcpkg install uvatlas:x64-linux
vcpkg install uvatlas[eigen]:x64-linux --recurse
vcpkg install uvatlas:arm64-linux
vcpkg install uvatlas[eigen]:arm64-linux --recurse

@walbourn
Copy link
Member Author

walbourn commented Mar 2, 2022

@BillyONeal

I don't understand the failures here. I tried rebasing to latest and they are still happening. They look like infrastructure problems from the logs:

Extracting 7zip...
msiexec failed while extracting 'D:\downloads\7z1900-x64.msi' with message:
T
##[error]vcpkg ci failed

@FrankXie05 FrankXie05 added the category:port-update The issue is with a library, which is requesting update new revision label Mar 2, 2022
@Cheney-W
Copy link
Contributor

Cheney-W commented Mar 2, 2022

It's a known issue about CI, we are fixing it.

@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Mar 2, 2022
@vicroms vicroms merged commit ac392a1 into microsoft:master Mar 2, 2022
@walbourn walbourn deleted the feb2022dx branch March 2, 2022 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants