Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fmt] fix invalid command #23335

Merged
merged 1 commit into from
Mar 2, 2022
Merged

Conversation

Adela0814
Copy link
Contributor

Fix #23316

Failures:
fatal error C1021: invalid preprocessor command 'warning' when compile using VS2019

MSVC uses the syntax:
#pragma message ( "your warning text here" )
The usual #warning syntax generates a fatal error
C1021: invalid preprocessor command 'warning'

Add a patch in fmt to fix it.

@Adela0814 Adela0814 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Mar 1, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/fmt/vcpkg.json

Valid values for the license field can be found in the documentation

@Adela0814 Adela0814 marked this pull request as ready for review March 2, 2022 06:31
@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Mar 2, 2022
@vicroms vicroms merged commit 4534601 into microsoft:master Mar 2, 2022
@Adela0814 Adela0814 deleted the Dev/Mengna/spdlog branch January 16, 2023 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spdlog benchmark failed to build (error).
4 participants