Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libe57] update to 1.1.332; fix debug library lookup #23336

Merged
merged 3 commits into from
Mar 7, 2022

Conversation

maz-1
Copy link
Contributor

@maz-1 maz-1 commented Mar 1, 2022

Describe the pull request

  • What does your PR fix?

    update to 1.1.332
    fix debug library lookup problem in cmake

  • Which triplets are supported/not supported? Have you updated the [CI baseline]

    all

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for libe57 but no changes to version or port version.
-- Version: 1.1.312#1
-- Old SHA: ed9a20551a07f8dbcb637af8394653c326e95aac
-- New SHA: cce3615484f983290c375729780146d180e22b19
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout b726998b816c583ff549e29d98fe06dbd6d0f694 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index 7f0edb7..c896bc9 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -3453,7 +3453,7 @@
       "port-version": 3
     },
     "libe57": {
-      "baseline": "1.1.332",
+      "baseline": "1.1.312",
       "port-version": 1
     },
     "libe57format": {
diff --git a/versions/l-/libe57.json b/versions/l-/libe57.json
index 8db7a2a..e21d693 100644
--- a/versions/l-/libe57.json
+++ b/versions/l-/libe57.json
@@ -1,10 +1,5 @@
 {
   "versions": [
-    {
-      "git-tree": "cce3615484f983290c375729780146d180e22b19",
-      "version-semver": "1.1.332",
-      "port-version": 0
-    },
     {
       "git-tree": "ed9a20551a07f8dbcb637af8394653c326e95aac",
       "version-semver": "1.1.312",

@FrankXie05 FrankXie05 added the category:port-update The issue is with a library, which is requesting update new revision label Mar 1, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for libe57 but no changes to version or port version.
-- Version: 1.1.312#1
-- Old SHA: ed9a20551a07f8dbcb637af8394653c326e95aac
-- New SHA: cce3615484f983290c375729780146d180e22b19
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout b726998b816c583ff549e29d98fe06dbd6d0f694 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/l-/libe57.json b/versions/l-/libe57.json
index 8db7a2a..e21d693 100644
--- a/versions/l-/libe57.json
+++ b/versions/l-/libe57.json
@@ -1,10 +1,5 @@
 {
   "versions": [
-    {
-      "git-tree": "cce3615484f983290c375729780146d180e22b19",
-      "version-semver": "1.1.332",
-      "port-version": 0
-    },
     {
       "git-tree": "ed9a20551a07f8dbcb637af8394653c326e95aac",
       "version-semver": "1.1.312",

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for libe57 but no changes to version or port version.
-- Version: 1.1.312#1
-- Old SHA: ed9a20551a07f8dbcb637af8394653c326e95aac
-- New SHA: cce3615484f983290c375729780146d180e22b19
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout b726998b816c583ff549e29d98fe06dbd6d0f694 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index 7f0edb7..c896bc9 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -3453,7 +3453,7 @@
       "port-version": 3
     },
     "libe57": {
-      "baseline": "1.1.332",
+      "baseline": "1.1.312",
       "port-version": 1
     },
     "libe57format": {
diff --git a/versions/l-/libe57.json b/versions/l-/libe57.json
index 8db7a2a..e21d693 100644
--- a/versions/l-/libe57.json
+++ b/versions/l-/libe57.json
@@ -1,10 +1,5 @@
 {
   "versions": [
-    {
-      "git-tree": "cce3615484f983290c375729780146d180e22b19",
-      "version-semver": "1.1.332",
-      "port-version": 0
-    },
     {
       "git-tree": "ed9a20551a07f8dbcb637af8394653c326e95aac",
       "version-semver": "1.1.312",

@Adela0814
Copy link
Contributor

@maz-1 Thanks for your PR, The CI test failed in x86-windows, please take a look.

@maz-1
Copy link
Contributor Author

maz-1 commented Mar 4, 2022

@maz-1 Thanks for your PR, The CI test failed in x86-windows, please take a look.

https://dev.azure.com/vcpkg/public/_build/results?buildId=68156&view=logs&j=0e4f438e-abd7-54ec-b41c-43e75bdf9257&t=66b08dbc-1512-5574-68fc-23fcdd025f86&l=18

It says msiexec failed while extracting 'D:\downloads\7z1900-x64.msi'
Seems to be a failure with devops rather than a problem in the port.

@Adela0814
Copy link
Contributor

@maz-1 You need to update port version database
Error:

Found the following errors:
##[error]versions/l-/libe57.json(2,): error : While reading versions for port libe57 from file: version/l-/libe57.json
File declares version `1.1.312#1` with SHA: ed9a20551a07f8dbcb637af8394653c326e95aac
But local port with the same version has a different SHA: cce3615484f983290c375729780146d180e22b19
Please update the port's version fields and then run:

    vcpkg x-add-version libe57
    git add versions
    git commit -m "Update version database"

to add a new version.

To attempt to resolve all errors at once, run:

    vcpkg x-add-version --all

##[error]PowerShell exited with code '1'.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout bd602277bf7fc3188b3d086b302c6840464db900 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/l-/libe57.json b/versions/l-/libe57.json
index 806f997..8664e63 100644
--- a/versions/l-/libe57.json
+++ b/versions/l-/libe57.json
@@ -6,7 +6,7 @@
       "port-version": 1
     },
     {
-      "git-tree": "cce3615484f983290c375729780146d180e22b19",
+      "git-tree": "ed9a20551a07f8dbcb637af8394653c326e95aac",
       "version-semver": "1.1.312",
       "port-version": 1
     },

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/libe57/vcpkg.json

Valid values for the license field can be found in the documentation

@Adela0814 Adela0814 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Mar 7, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout bd602277bf7fc3188b3d086b302c6840464db900 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/l-/libe57.json b/versions/l-/libe57.json
index e19b8d1..0371207 100644
--- a/versions/l-/libe57.json
+++ b/versions/l-/libe57.json
@@ -6,7 +6,7 @@
       "port-version": 1
     },
     {
-      "git-tree": "cce3615484f983290c375729780146d180e22b19",
+      "git-tree": "ed9a20551a07f8dbcb637af8394653c326e95aac",
       "version-semver": "1.1.312",
       "port-version": 1
     },

@vicroms vicroms merged commit 106bbc1 into microsoft:master Mar 7, 2022
@maz-1 maz-1 deleted the libe57 branch March 8, 2022 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants