[opencv] Fix import paths for debug Android builds

[hh10k]

• What does your PR fix?

Fixes OpenCV 4 import paths for Android debug builds.

For Android builds OpenCV places library outputs under a sdk/native/staticlibs/<arch> directory, and vcpkg correctly copies these to the install directory as either vcpkg_installed/<triplet>/sdk/... for release or vcpkg_installed/<triplet>/debug/sdk/... for debug, however the OpenCVModules-debug.cmake is not automatically updated by vcpkg_cmake_config_fixup to reference the debug directory.

• Which triplets are supported/not supported? Have you updated the CI baseline?

OpenCV will only use this sdk directory when the ANDROID cmake variable is set. I'm not aware of behaviour change based on the triplet.

• Does your PR follow the maintainer guide?

I have read the guide and I think this PR follows it.

• If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

[ghost]

All CLA requirements met.

[JackBoosY]

Please click "ready for review" then I will review this PR.

[talregev]

@hh10k Is it ready for review?

[hh10k]

Yes, this is ready for review. It includes the fix for OpenCV 3 and 4, and all the changes from ./vcpkg x-add-version --all have been committed.

[talregev]

Yes, this is ready for review. It includes the fix for OpenCV 3 and 4, and all the changes from ./vcpkg x-add-version --all have been committed.

@JackBoosY FYI

[cenit]

just noticed one thing:
the PR is not ready for single-config builds

please try to test your pr using the x64-windows-release community triplet and check if it works

i suppose you have to wrap your fix within the clause if (NOT VCPKG_BUILD_TYPE)

[hh10k]

@cenit @JackBoosY I tested with the x64-osx-release triplet and there was a problem, so I added if (NOT VCPKG_BUILD_TYPE OR VCPKG_BUILD_TYPE STREQUAL "debug") to both portfiles. That is commonly used elsewhere in other ports.

I couldn't confirm whether a debug single configuration build would actually work though, because some dependency builds are broken.

[cenit]

single config debug triplets cannot work by design in vcpkg so that's not a problem

about the fix, a simpler clause like the one i told you was similarly effective, but yours is ok too

[adapptor-kurt]

single config debug triplets cannot work by design in vcpkg so that's not a problem

about the fix, a simpler clause like the one i told you was similarly effective, but yours is ok too

Ah, sorry for making it more complicated than necessary. I saw 164 instances of VCPKG_BUILD_TYPE STREQUAL "debug" in the codebase so assumed it was also possible.

[cenit]

until I asked and insisted with a test PR in #16110, the stance about the broken debug-only triplets was not clear. That's why in many places we were still hoping about that possibility

[JackBoosY]

LGTM.

[BillyONeal]

until I asked and insisted with a test PR in #16110, the stance about the broken debug-only triplets was not clear. That's why in many places we were still hoping about that possibility

Maybe we should add something like VCPKG_BUILD_INCLUDES_DEBUG or similar and replace all occurrences?

[BillyONeal]

Thanks :)

[cenit]

until I asked and insisted with a test PR in #16110, the stance about the broken debug-only triplets was not clear. That's why in many places we were still hoping about that possibility

Maybe we should add something like VCPKG_BUILD_INCLUDES_DEBUG or similar and replace all occurrences?

just the first part is ok

if (NOT VCPKG_BUILD_TYPE)

without the OR VCPKG_BUILD_TYPE STREQUAL "debug" which is an impossible case

which also means that somehow the only valid value for the build type is "release", but since release could be overridden to have debug, it has lost its meaning. It should just be spelled as "vcpkg_single_config_build"...