[zlib] Ignore external ZLIB_DLL

[dg0yt]

• What does your PR fix?

  Hardcodes the triplet linkage into the installed headers, so that usage no longer depends on external definition of ZLIB_DLL.
  For example, GDAL always applies ZLIB_DLL. Noticed in log from [gdal] Update to v3.5.2 #26676 (comment):

  LINK : warning LNK4286: symbol 'crc32' defined in 'zlib.lib(crc32.obj)' is imported by 'gdal.lib(cpl_minizip_unzip.cpp.obj)'
  LINK : warning LNK4217: symbol 'deflateInit_' defined in 'zlib.lib(deflate.obj)' is imported by 'gdal.lib(cpl_vsil_gzip.cpp.obj)' in function 'CPLZLibDeflate'
  

  Given the broad impact of port zlib changes, this PR should be considered for combination with other zlib changes:
  [zlib] Fix CVE-2022-37434 #26792

  Follow-up changes:

  • Update minizip to the same source version as zlib.
  • Revise libkml, triggered from zlib/minizip issues.

• Which triplets are supported/not supported? Have you updated the CI baseline?

  unchanged, no

• Does your PR follow the maintainer guide?

  yes

• If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

  yes

[Neumann-A]

Why has this not been a problem before?

[dg0yt]

Why has this not been a problem before?

a) Packages tend to unconditionally set ZLIB_DLL.
Evidence: gdal as mentioned aboved; git grep ZLIB_DLL
b) There is only a warning in static builds, not an error.
c) Contributors and reviewers don't care for this warning. In particular when connected with other errors
Evidence: the mentioned gdal issue; https://github.com/microsoft/vcpkg/search?q=LNK4217&type=issues

[dg0yt]

libkml probably stumbles over a mix of headers from zlib and its vendored copy of minizip.

[github-actions]

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

• ports/libkml/portfile.cmake

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

• ports/minizip/vcpkg.json

Valid values for the license field can be found in the documentation

[github-actions]

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

• ports/minizip/vcpkg.json

Valid values for the license field can be found in the documentation

[github-actions]

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout d52632d9a0c4a5b57de285b1e03722a067dd80eb -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 6e8968a..8edb36d 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -3834,7 +3834,7 @@
     },
     "libkml": {
       "baseline": "1.3.0",
-      "port-version": 8
+      "port-version": 9
     },
     "liblas": {
       "baseline": "1.8.1",
diff --git a/versions/l-/libkml.json b/versions/l-/libkml.json
index 8b24a12..7b37667 100644
--- a/versions/l-/libkml.json
+++ b/versions/l-/libkml.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "b251016911a5eeae287e3a5bd67a30e3213b2b8e",
+      "version": "1.3.0",
+      "port-version": 9
+    },
     {
       "git-tree": "1ce9dd050baf9ae42da2bb0c6d0feae1241b6e01",
       "version-string": "1.3.0",

[dg0yt]

I want to improve the libkml mingw patch.

[github-actions]

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 5f144173006dbeea7b9cb017775675606666a207 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 9f9b357..0c8358f 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -3838,7 +3838,7 @@
     },
     "libkml": {
       "baseline": "1.3.0",
-      "port-version": 8
+      "port-version": 9
     },
     "liblas": {
       "baseline": "1.8.1",
@@ -4769,8 +4769,8 @@
       "port-version": 1
     },
     "minizip": {
-      "baseline": "1.2.11",
-      "port-version": 11
+      "baseline": "1.2.12",
+      "port-version": 0
     },
     "minizip-ng": {
       "baseline": "3.0.5",
diff --git a/versions/l-/libkml.json b/versions/l-/libkml.json
index 8b24a12..5797ff9 100644
--- a/versions/l-/libkml.json
+++ b/versions/l-/libkml.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "9941e66029546372544fed13066e9a9756981dd3",
+      "version": "1.3.0",
+      "port-version": 9
+    },
     {
       "git-tree": "1ce9dd050baf9ae42da2bb0c6d0feae1241b6e01",
       "version-string": "1.3.0",
diff --git a/versions/m-/minizip.json b/versions/m-/minizip.json
index 9c1239b..c85a7b5 100644
--- a/versions/m-/minizip.json
+++ b/versions/m-/minizip.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "65a32bfac58033a215e271db94d5e022fce816e3",
+      "version-semver": "1.2.12",
+      "port-version": 0
+    },
     {
       "git-tree": "528703ed8d2b78aeaa55695765535efafa24540b",
       "version-semver": "1.2.11",

[BillyONeal]

I love this change. Are you saying you want me to cherry pick it into #27226 or vice versa?

[dg0yt]

Please do the cherry-pick.

[BillyONeal]

Thanks again!