Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[halide] No vendored wasm #26968

Merged
merged 6 commits into from
Sep 28, 2022
Merged

[halide] No vendored wasm #26968

merged 6 commits into from
Sep 28, 2022

Conversation

Thomas1664
Copy link
Contributor

Describe the pull request

  • What does your PR fix?

    This port used a vendored version of wasm. I disabled this feature.

github-actions[bot]
github-actions bot previously approved these changes Sep 24, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/halide/vcpkg.json

Valid values for the license field can be found in the documentation

@JonLiu1993 JonLiu1993 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Sep 26, 2022
@JonLiu1993
Copy link
Member

@Thomas1664 ,Thanks for your pr, please add "license" in vcpkg.json file.

@Thomas1664
Copy link
Contributor Author

@Thomas1664 ,Thanks for your pr, please add "license" in vcpkg.json file.

I didn't add one because I'm unsure what the correct expression is. See the upstream license file: https://github.com/halide/Halide/blob/main/LICENSE.txt

@JonLiu1993
Copy link
Member

@Thomas1664 ,Thanks for your pr, please add "license" in vcpkg.json file.

I didn't add one because I'm unsure what the correct expression is. See the upstream license file: https://github.com/halide/Halide/blob/main/LICENSE.txt

https://halide-lang.org/
Halide is open source, under a commercially permissive MIT license. We encourage you to use it in other projects, open source or commercial!

@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Sep 28, 2022
@vicroms vicroms merged commit 2d6ac7b into microsoft:master Sep 28, 2022
@Thomas1664 Thomas1664 deleted the halide branch September 28, 2022 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants