Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[trantor] Update to 1.5.7 [drogon] Update to 1.8.1 #26994

Merged
merged 3 commits into from
Oct 5, 2022
Merged

[trantor] Update to 1.5.7 [drogon] Update to 1.8.1 #26994

merged 3 commits into from
Oct 5, 2022

Conversation

an-tao
Copy link
Contributor

@an-tao an-tao commented Sep 26, 2022

No description provided.

github-actions[bot]
github-actions bot previously approved these changes Sep 26, 2022
View reviewed changes
@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Sep 27, 2022
@JonLiu1993
Copy link
Member

@an-tao, Thanks for your pr, this is error log, please take a look:

FAILED: CMakeFiles/drogon.dir/orm_lib/src/RestfulController.cc.obj 
C:\PROGRA~1\MICROS~1\2022\ENTERP~1\VC\Tools\MSVC\1433~1.316\bin\Hostx64\x86\cl.exe   /TP -DUSE_BROTLI -Ddrogon_EXPORTS -ID:\buildtrees\drogon\src\v1.8.0-dfb5ab6251.clean\lib\inc -ID:\buildtrees\drogon\src\v1.8.0-dfb5ab6251.clean\orm_lib\inc -ID:\buildtrees\drogon\src\v1.8.0-dfb5ab6251.clean\nosql_lib\redis\inc -ID:\buildtrees\drogon\x86-windows-dbg -ID:\buildtrees\drogon\src\v1.8.0-dfb5ab6251.clean\trantor -ID:\buildtrees\drogon\x86-windows-dbg\exports -ID:\buildtrees\drogon\src\v1.8.0-dfb5ab6251.clean\third_party\mman-win32 -external:ID:\installed\x86-windows\include -external:W0 /nologo /DWIN32 /D_WINDOWS /W3 /utf-8 /GR /EHsc /MP  /D_DEBUG /MDd /Z7 /Ob0 /Od /RTC1  /utf-8 /wd4251 /wd4275 -std:c++20 /showIncludes /FoCMakeFiles\drogon.dir\orm_lib\src\RestfulController.cc.obj /FdCMakeFiles\drogon.dir\ /FS -c D:\buildtrees\drogon\src\v1.8.0-dfb5ab6251.clean\orm_lib\src\RestfulController.cc
D:\buildtrees\drogon\src\v1.8.0-dfb5ab6251.clean\orm_lib\inc\drogon/orm/Mapper.h(24): error C2371: 'ssize_t': redefinition; different basic types
D:\installed\x86-windows\include\trantor/utils/MsgBuffer.h(25): note: see declaration of 'ssize_t'
[51/58] C:\PROGRA~1\MICROS~1\2022\ENTERP~1\VC\Tools\MSVC\1433~1.316\bin\Hostx64\x86\cl.exe   /TP -DUSE_BROTLI -Ddrogon_EXPORTS -ID:\buildtrees\drogon\src\v1.8.0-dfb5ab6251.clean\lib\inc -ID:\buildtrees\drogon\src\v1.8.0-dfb5ab6251.clean\orm_lib\inc -ID:\buildtrees\drogon\src\v1.8.0-dfb5ab6251.clean\nosql_lib\redis\inc -ID:\buildtrees\drogon\x86-windows-dbg -ID:\buildtrees\drogon\src\v1.8.0-dfb5ab6251.clean\trantor -ID:\buildtrees\drogon\x86-windows-dbg\exports -ID:\buildtrees\drogon\src\v1.8.0-dfb5ab6251.clean\third_party\mman-win32 -external:ID:\installed\x86-windows\include -external:W0 /nologo /DWIN32 /D_WINDOWS /W3 /utf-8 /GR /EHsc /MP  /D_DEBUG /MDd /Z7 /Ob0 /Od /RTC1  /utf-8 /wd4251 /wd4275 -std:c++20 /showIncludes /FoCMakeFiles\drogon.dir\orm_lib\src\DbConnection.cc.obj /FdCMakeFiles\drogon.dir\ /FS -c D:\buildtrees\drogon\src\v1.8.0-dfb5ab6251.clean\orm_lib\src\DbConnection.cc
D:\buildtrees\drogon\src\v1.8.0-dfb5ab6251.clean\orm_lib\inc\drogon/orm/SqlBinder.h(377): warning C4244: 'argument': conversion from 'T' to 'u_short', possible loss of data

@an-tao
Copy link
Contributor Author

an-tao commented Sep 27, 2022

@an-tao, Thanks for your pr, this is error log, please take a look:

FAILED: CMakeFiles/drogon.dir/orm_lib/src/RestfulController.cc.obj 
C:\PROGRA~1\MICROS~1\2022\ENTERP~1\VC\Tools\MSVC\1433~1.316\bin\Hostx64\x86\cl.exe   /TP -DUSE_BROTLI -Ddrogon_EXPORTS -ID:\buildtrees\drogon\src\v1.8.0-dfb5ab6251.clean\lib\inc -ID:\buildtrees\drogon\src\v1.8.0-dfb5ab6251.clean\orm_lib\inc -ID:\buildtrees\drogon\src\v1.8.0-dfb5ab6251.clean\nosql_lib\redis\inc -ID:\buildtrees\drogon\x86-windows-dbg -ID:\buildtrees\drogon\src\v1.8.0-dfb5ab6251.clean\trantor -ID:\buildtrees\drogon\x86-windows-dbg\exports -ID:\buildtrees\drogon\src\v1.8.0-dfb5ab6251.clean\third_party\mman-win32 -external:ID:\installed\x86-windows\include -external:W0 /nologo /DWIN32 /D_WINDOWS /W3 /utf-8 /GR /EHsc /MP  /D_DEBUG /MDd /Z7 /Ob0 /Od /RTC1  /utf-8 /wd4251 /wd4275 -std:c++20 /showIncludes /FoCMakeFiles\drogon.dir\orm_lib\src\RestfulController.cc.obj /FdCMakeFiles\drogon.dir\ /FS -c D:\buildtrees\drogon\src\v1.8.0-dfb5ab6251.clean\orm_lib\src\RestfulController.cc
D:\buildtrees\drogon\src\v1.8.0-dfb5ab6251.clean\orm_lib\inc\drogon/orm/Mapper.h(24): error C2371: 'ssize_t': redefinition; different basic types
D:\installed\x86-windows\include\trantor/utils/MsgBuffer.h(25): note: see declaration of 'ssize_t'
[51/58] C:\PROGRA~1\MICROS~1\2022\ENTERP~1\VC\Tools\MSVC\1433~1.316\bin\Hostx64\x86\cl.exe   /TP -DUSE_BROTLI -Ddrogon_EXPORTS -ID:\buildtrees\drogon\src\v1.8.0-dfb5ab6251.clean\lib\inc -ID:\buildtrees\drogon\src\v1.8.0-dfb5ab6251.clean\orm_lib\inc -ID:\buildtrees\drogon\src\v1.8.0-dfb5ab6251.clean\nosql_lib\redis\inc -ID:\buildtrees\drogon\x86-windows-dbg -ID:\buildtrees\drogon\src\v1.8.0-dfb5ab6251.clean\trantor -ID:\buildtrees\drogon\x86-windows-dbg\exports -ID:\buildtrees\drogon\src\v1.8.0-dfb5ab6251.clean\third_party\mman-win32 -external:ID:\installed\x86-windows\include -external:W0 /nologo /DWIN32 /D_WINDOWS /W3 /utf-8 /GR /EHsc /MP  /D_DEBUG /MDd /Z7 /Ob0 /Od /RTC1  /utf-8 /wd4251 /wd4275 -std:c++20 /showIncludes /FoCMakeFiles\drogon.dir\orm_lib\src\DbConnection.cc.obj /FdCMakeFiles\drogon.dir\ /FS -c D:\buildtrees\drogon\src\v1.8.0-dfb5ab6251.clean\orm_lib\src\DbConnection.cc
D:\buildtrees\drogon\src\v1.8.0-dfb5ab6251.clean\orm_lib\inc\drogon/orm/SqlBinder.h(377): warning C4244: 'argument': conversion from 'T' to 'u_short', possible loss of data

This is related to the ssize_t issue on windows, can I upgrade trantor and drogon together in the same PR? Thanks.

@JonLiu1993
Copy link
Member

@an-tao, Thanks for your pr, this is error log, please take a look:

FAILED: CMakeFiles/drogon.dir/orm_lib/src/RestfulController.cc.obj 
C:\PROGRA~1\MICROS~1\2022\ENTERP~1\VC\Tools\MSVC\1433~1.316\bin\Hostx64\x86\cl.exe   /TP -DUSE_BROTLI -Ddrogon_EXPORTS -ID:\buildtrees\drogon\src\v1.8.0-dfb5ab6251.clean\lib\inc -ID:\buildtrees\drogon\src\v1.8.0-dfb5ab6251.clean\orm_lib\inc -ID:\buildtrees\drogon\src\v1.8.0-dfb5ab6251.clean\nosql_lib\redis\inc -ID:\buildtrees\drogon\x86-windows-dbg -ID:\buildtrees\drogon\src\v1.8.0-dfb5ab6251.clean\trantor -ID:\buildtrees\drogon\x86-windows-dbg\exports -ID:\buildtrees\drogon\src\v1.8.0-dfb5ab6251.clean\third_party\mman-win32 -external:ID:\installed\x86-windows\include -external:W0 /nologo /DWIN32 /D_WINDOWS /W3 /utf-8 /GR /EHsc /MP  /D_DEBUG /MDd /Z7 /Ob0 /Od /RTC1  /utf-8 /wd4251 /wd4275 -std:c++20 /showIncludes /FoCMakeFiles\drogon.dir\orm_lib\src\RestfulController.cc.obj /FdCMakeFiles\drogon.dir\ /FS -c D:\buildtrees\drogon\src\v1.8.0-dfb5ab6251.clean\orm_lib\src\RestfulController.cc
D:\buildtrees\drogon\src\v1.8.0-dfb5ab6251.clean\orm_lib\inc\drogon/orm/Mapper.h(24): error C2371: 'ssize_t': redefinition; different basic types
D:\installed\x86-windows\include\trantor/utils/MsgBuffer.h(25): note: see declaration of 'ssize_t'
[51/58] C:\PROGRA~1\MICROS~1\2022\ENTERP~1\VC\Tools\MSVC\1433~1.316\bin\Hostx64\x86\cl.exe   /TP -DUSE_BROTLI -Ddrogon_EXPORTS -ID:\buildtrees\drogon\src\v1.8.0-dfb5ab6251.clean\lib\inc -ID:\buildtrees\drogon\src\v1.8.0-dfb5ab6251.clean\orm_lib\inc -ID:\buildtrees\drogon\src\v1.8.0-dfb5ab6251.clean\nosql_lib\redis\inc -ID:\buildtrees\drogon\x86-windows-dbg -ID:\buildtrees\drogon\src\v1.8.0-dfb5ab6251.clean\trantor -ID:\buildtrees\drogon\x86-windows-dbg\exports -ID:\buildtrees\drogon\src\v1.8.0-dfb5ab6251.clean\third_party\mman-win32 -external:ID:\installed\x86-windows\include -external:W0 /nologo /DWIN32 /D_WINDOWS /W3 /utf-8 /GR /EHsc /MP  /D_DEBUG /MDd /Z7 /Ob0 /Od /RTC1  /utf-8 /wd4251 /wd4275 -std:c++20 /showIncludes /FoCMakeFiles\drogon.dir\orm_lib\src\DbConnection.cc.obj /FdCMakeFiles\drogon.dir\ /FS -c D:\buildtrees\drogon\src\v1.8.0-dfb5ab6251.clean\orm_lib\src\DbConnection.cc
D:\buildtrees\drogon\src\v1.8.0-dfb5ab6251.clean\orm_lib\inc\drogon/orm/SqlBinder.h(377): warning C4244: 'argument': conversion from 'T' to 'u_short', possible loss of data

This is related to the ssize_t issue on windows, can I upgrade trantor and drogon together in the same PR? Thanks.

That's ok.

@an-tao an-tao changed the title [trantor] Update to 1.5.7 [trantor] Update to 1.5.7 [drogon] Update to 1.8.1 Sep 28, 2022
@vicroms vicroms merged commit 73351a3 into microsoft:master Oct 5, 2022
@an-tao an-tao deleted the trantor branch October 6, 2022 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@JonLiu1993 JonLiu1993

Labels
category:port-update The issue is with a library, which is requesting update new revision
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@an-tao @JonLiu1993 @vicroms