Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[google-cloud-cpp] fix feature dependencies #27001

Merged
merged 3 commits into from
Sep 29, 2022
Merged

[google-cloud-cpp] fix feature dependencies #27001

merged 3 commits into from
Sep 29, 2022

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Sep 26, 2022

Some features in google-cloud-cpp depend on other features. This was
not captured in the vcpkg.json file.

  • What does your PR fix?

N/A

  • Which triplets are supported/not supported? Have you updated the CI baseline?

No change.

Yes.

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes.

github-actions[bot]
github-actions bot previously approved these changes Sep 26, 2022
@coryan coryan marked this pull request as ready for review September 26, 2022 21:00
@Cheney-W Cheney-W added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function and removed info:reviewed Pull Request changes follow basic guidelines labels Sep 27, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for google-cloud-cpp have changed but the version was not updated
version: 2.2.0#1
old SHA: 4a7d53c5b4aec877a0d7cc332d475fc0793a50b2
new SHA: 1787308d659051c50c95298d855cd7ad5308d8b4
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

@Cheney-W Cheney-W added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function labels Sep 29, 2022
@Cheney-W
Copy link
Contributor

New features passed with following triplets:
x86-windows
x64-windows
x64-windows-static

@vicroms vicroms merged commit 7acd91a into microsoft:master Sep 29, 2022
@coryan coryan deleted the google-cloud-cpp-fix-feature-dependencies branch September 30, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants