[easyexif] create a new port #27118
Merged
[easyexif] create a new port #27118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
dg0yt
reviewed
Oct 7, 2022
Comment on lines
+11
to
+13
| PROPERTIES | ||
| CXX_STANDARD 11 | ||
| PUBLIC_HEADER exif.h |
Comment on lines
+17
to
+19
| PUBLIC_HEADER DESTINATION ${CMAKE_INSTALL_INCLUDEDIR} | ||
| ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR} | ||
| LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR} |
| ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR} | ||
| LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR} | ||
| ) | ||
| install(FILES LICENSE DESTINATION ${CMAKE_INSTALL_DATAROOTDIR}/${PROJECT_NAME}) # share/easyexif |
There was a problem hiding this comment.
Missing Double quotes. But actually obsolete, because it is handled in the portfile, including renaming to copyright.
| file(REMOVE_RECURSE | ||
| "${CURRENT_PACKAGES_DIR}/debug/include" | ||
| "${CURRENT_PACKAGES_DIR}/debug/share" | ||
| "${CURRENT_PACKAGES_DIR}/share" |
| "version-date": "2022-10-07", | ||
| "description": "Tiny ISO-compliant C++ EXIF parsing library, third-party dependency free", | ||
| "homepage": "https://github.com/mayanklahiri/easyexif", | ||
| "license": null, |
There was a problem hiding this comment.
https://tools.spdx.org/app/check_license/ says: "Close match found! The following license ID(s) match: BSD-2-Clause"
There was a problem hiding this comment.
Oh there was a tool! I will make another PR with this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does your PR fix?
Create a new port with https://github.com/mayanklahiri/easyexif.
My team started using the project recently. Opening a PR for integration.
Which triplets are supported/not supported? Have you updated the CI baseline?
Create a very small static library with CMakeLists.txt.
Every triplet must be available.
Does your PR follow the maintainer guide?
Yes.