Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libui] Revise platform support #27141

Merged
merged 4 commits into from
Oct 9, 2022
Merged

[libui] Revise platform support #27141

merged 4 commits into from
Oct 9, 2022

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Oct 8, 2022

  • What does your PR fix?

    Modernizes the port.
    Adds supports field - only major desktop platforms supported.
    Adds gtk3 dependency for linux.
    Fixes CI baseline regression (unexpected pass) for x64-linux.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    cf. supports, yes

  • Does your PR follow the maintainer guide?

    yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    yes

github-actions[bot]
github-actions bot previously approved these changes Oct 8, 2022
@LilyWangLL LilyWangLL added the category:port-bug The issue is with a library, which is something the port should already support label Oct 8, 2022
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Oct 8, 2022
@vicroms vicroms merged commit 26a0995 into microsoft:master Oct 9, 2022
@dg0yt dg0yt deleted the libui branch October 9, 2022 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants