[Docs] Vcpkg via FetchContent #27158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
|
Please add |
Cheney-W
added
category:documentation
Neumann-A
reviewed
Oct 10, 2022
|
I changed the cmake min to 3.14 since that's when FetchContent_MakeAvailable was introduced. |
juan-lunarg
reviewed
Oct 11, 2022
jpr42
requested review from
autoantwort and
Neumann-A
and removed request for
autoantwort
|
I think this PR looks good now based on the feedback |
autoantwort
reviewed
Oct 12, 2022
Cheney-W
reviewed
Oct 12, 2022
Show how to easily incorporate vcpkg into a CMake project without git submodules
Cheney-W
added
info:reviewed
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Cheney-W
approved these changes
Oct 13, 2022
|
Looks like everything is good now. Is there anything else I need to sort out? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show how to easily incorporate vcpkg into a CMake project without git submodules