[poco] update to 1.12.4

[russelltg]

Update poco to 1.12.2

Fixes #25928

• Which triplets are supported/not supported? Have you updated the CI baseline?

  all

• Does your PR follow the maintainer guide?

  Yes

• If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

  Yes, but there may be issues with this PR still

[github-actions]

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

• ports/poco/portfile.cmake

[MonicaLiu0311]

Thanks for your PR. Please get failure logs here. Please ping me if you need any help.

[MonicaLiu0311]

@russelltg
I have a question, can you please answer it?

Old Name: fix_dependency.patch, Location: Lines 148-204, Action: Delete.

You removed the following patch for the three files that changed targetName from pcre to unofficial-pcre, but the upstream code hasn't changed, and I didn't find an addition to this in your new patch file(0003-fix-dependency.patch).

Lines 148-204:

diff --git a/Foundation/CMakeLists.txt b/Foundation/CMakeLists.txt
...
diff --git a/Foundation/cmake/PocoFoundationConfig.cmake b/Foundation/cmake/PocoFoundationConfig.cmake
...
diff --git a/XML/CMakeLists.txt b/XML/CMakeLists.txt
...

[dg0yt]

vcpkg doesn't want these headers.

[dg0yt]

BUILD_SHARED_LIBS is a standard CMake variable and automatical set by vcpkg_cmake_configure.
(Maybe all the POCO_SHARED/POCO_STATIC is obsolete now?)

[russelltg]

Yes, POCO_STATIC is deprecated. I'll remove this

[dg0yt]

This file shouldn't change at all?

[russelltg]

yeah the FROM...TO did change but I can revert that to clean up the diff (I'm going to keep the rename though if that's okay)

[dg0yt]

Is this to modify target Foundation? add_definitions acts globally, but IIUC only to target created after the command.

[russelltg]

Adds definitions to the compiler command line for targets in the current directory, whether added before or after this command is invoked, and for the ones in sub-directories added after
https://cmake.org/cmake/help/latest/command/add_definitions.html

It only affects the current and child tress, so should be equivalent to a target_compile_definitions.

[russelltg]

@MonicaLiu0311 Great question, this is because Poco 1.12 moves from PCRE to PCRE2. There is no PCRE2Config.cmake that gets installed with the PCRE2 vcpkg package, so I'm just using their internal FindPCRE2.cmake (that gets installed into share/poco) with some modifications

[github-actions]

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for poco have changed but the version was not updated
version: 1.12.2
old SHA: 3c19b18886b438f08bd1e093beb3d6c1f178a613
new SHA: c610ac035d217e5e7700730c0a0b026bce7008fc
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

[MonicaLiu0311]

@MonicaLiu0311 Great question, this is because Poco 1.12 moves from PCRE to PCRE2. There is no PCRE2Config.cmake that gets installed with the PCRE2 vcpkg package, so I'm just using their internal FindPCRE2.cmake (that gets installed into share/poco) with some modifications

I see, thank you very much for your detailed answer.

[dg0yt]

I just noticed that there is already 1.12.3 now.

[BillyONeal]

Retagging this with reviewed to ensure I check again on Monday

[npc144]

1.12.4 is up which contains security fixes, might want to update again.

[BillyONeal]

I am not a fan of the "-D hack" but that was already there. Thanks for the update!

[russelltg]

Agreed, I'll file an issue with upstream, as I consider it a proper bug. And they can do a much better solution (there's a single define they can set that does the same thing but for all pcre2 symbols)