Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[expat] Fix build failure. #28368

Merged
merged 6 commits into from
Dec 19, 2022
Merged

[expat] Fix build failure. #28368

merged 6 commits into from
Dec 19, 2022

Conversation

Hoikas
Copy link
Contributor

@Hoikas Hoikas commented Dec 16, 2022

This fixes a build failure in the expat port due to VERSION no longer being set in the portfile. This was broken by #27547. I elected to hardwire the version numbers instead of reading vcpkg.json because vcpkg.json can have versions that are not expat versions, eg version-date.

  • What does your PR fix?

    Fixes
CMake Error at D:/Plasma/CyanWorlds.comEngine/build/vc++2022-x64/vcpkg_installed/x64-windows-plasma/share/vcpkg-cmake-config/vcpkg_cmake_config_fixup.cmake:36 (message):

  
  'D:/Plasma/CyanWorlds.comEngine/vcpkg/packages/expat_x64-windows-plasma/debug/lib/cmake/expat-'
  does not exist.
Call Stack (most recent call first):
  ports/expat/portfile.cmake:26 (vcpkg_cmake_config_fixup)
  scripts/ports.cmake:147 (include)



error: building expat:x64-windows-plasma failed with: BUILD_FAILED
  • Which triplets are supported/not supported? Have you updated the CI baseline?

    No change

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

github-actions[bot]
github-actions bot previously approved these changes Dec 16, 2022
@Hoikas Hoikas changed the title Fix expat [expat] Fix build failure. Dec 16, 2022
@dg0yt
Copy link
Contributor

dg0yt commented Dec 16, 2022

No. Add this add at the top (until it arrives in a central place):

vcpkg_minimum_required(VERSION 2022-10-12) # for ${VERSION}

It will tell you if your vcpkg tool is too old.

And use string(REPLACE ...) to transform the version to the git tag.

@Cheney-W Cheney-W added category:port-bug The issue is with a library, which is something the port should already support requires:author-response labels Dec 16, 2022
@Osyotr
Copy link
Contributor

Osyotr commented Dec 16, 2022

Hmm I thought it will be fixed in #27598

@dg0yt
Copy link
Contributor

dg0yt commented Dec 16, 2022

expat was missing. However, the CMake 3.25.1 PR has the general update.

github-actions[bot]
github-actions bot previously approved these changes Dec 17, 2022
@Hoikas
Copy link
Contributor Author

Hoikas commented Dec 17, 2022

Thanks for the tip. I've updated the PR to use the new functionality.

ports/expat/portfile.cmake Outdated Show resolved Hide resolved
ports/expat/portfile.cmake Outdated Show resolved Hide resolved
@Cheney-W Cheney-W added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Dec 19, 2022
@JavierMatosD
Copy link
Contributor

Thank you!

@JavierMatosD JavierMatosD merged commit cafd285 into microsoft:master Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants