-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[expat] Fix build failure. #28368
Merged
Merged
[expat] Fix build failure. #28368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No. Add this add at the top (until it arrives in a central place): vcpkg_minimum_required(VERSION 2022-10-12) # for ${VERSION} It will tell you if your vcpkg tool is too old. And use |
Cheney-W
added
category:port-bug
The issue is with a library, which is something the port should already support
requires:author-response
labels
Dec 16, 2022
Hmm I thought it will be fixed in #27598 |
expat was missing. However, the CMake 3.25.1 PR has the general update. |
Thanks for the tip. I've updated the PR to use the new functionality. |
dg0yt
suggested changes
Dec 17, 2022
Cheney-W
added
info:reviewed
Pull Request changes follow basic guidelines
and removed
requires:author-response
labels
Dec 19, 2022
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category:port-bug
The issue is with a library, which is something the port should already support
info:reviewed
Pull Request changes follow basic guidelines
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a build failure in the expat port due to
VERSION
no longer being set in the portfile. This was broken by #27547. I elected to hardwire the version numbers instead of reading vcpkg.json because vcpkg.json can have versions that are not expat versions, egversion-date
.What does your PR fix?
FixesWhich triplets are supported/not supported? Have you updated the CI baseline?
No change
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?Yes
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/