-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fastrtps] Fix the macro definition in thread #32921
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimwang118
added
category:port-bug
The issue is with a library, which is something the port should already support
info:internal
This PR or Issue was filed by the vcpkg team.
labels
Aug 3, 2023
LilyWangLL
previously approved these changes
Aug 3, 2023
dg0yt
reviewed
Aug 3, 2023
LilyWangLL
previously approved these changes
Aug 10, 2023
It would be better to use the cast solution suggested by @StephanTLavavej in eProsima/Fast-DDS#3783 (comment) . |
LilyWangLL
removed
the
info:reviewed
Pull Request changes follow basic guidelines
label
Aug 11, 2023
After applied this patch,
|
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category:port-bug
The issue is with a library, which is something the port should already support
info:internal
This PR or Issue was filed by the vcpkg team.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix vcpkg testing MSVC issues.
D:\buildtrees\fastrtps\src\v2.7.0-02c5279eff.clean\include\fastrtps/utils/TimedMutex.hpp(142): error C2065: '_Thrd_success': undeclared identifier
Starting from msvc 19.38.32926.95, the macro
_Thrd_success
is modified to_Thrd_result::_Success
in thread, thus causing the above error.We judge the
msvc
version incmakelists.txt
. If the version is greater than or equal to 19.38.32926.95, then modify the macro only used infastrtps
from_Thrd_success
to _Thrd_result::_Success.A issue 3783 has been submitted upstream.
SHA512s are updated for each updated downloadThe "supports" clause reflects platforms that may be fixed by this new versionAny fixed CI baseline entries are removed from that file.Any patches that are no longer applied are deleted from the port's directory../vcpkg x-add-version --all
and committing the result.