Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GEOS] Generate debug library names with d suffix #3371

Merged
merged 2 commits into from
May 1, 2018
Merged

[GEOS] Generate debug library names with d suffix #3371

merged 2 commits into from
May 1, 2018

Conversation

mloskot
Copy link
Contributor

@mloskot mloskot commented Apr 28, 2018

Applies to current port of GEOS 3.6.2
Follows discussion on Slack hannel #vcpkg


Currently geos.lib name is used for both, debug and optimised
GEOS libraries. This leads to situation when:

find_library(GEOS_LIBRARY_DEBUG NAMES geos)
find_library(GEOS_LIBRARY_RELEASE NAMES geos)

finds the same library for both

GEOS_LIBRARY_DEBUG=D:/vcpkg/installed/x64-windows/debug/lib/geos.lib
GEOS_LIBRARY_RELEASE=D:/vcpkg/installed/x64-windows/debug/lib/geos.lib

This is minimal patch that works around the problem.

Next, complete fix should be submitted to GEOS upstream,
preferably using exported targets.

mloskot and others added 2 commits April 30, 2018 10:23
Currently geos.lib name is used for both, debug and optimised
GEOS libraries. This leads to situation when:
```
find_library(GEOS_LIBRARY_DEBUG NAMES geos)
find_library(GEOS_LIBRARY_RELEASE NAMES geos)
```

finds the same library for both
```
GEOS_LIBRARY_DEBUG=D:/vcpkg/installed/x64-windows/debug/lib/geos.lib
GEOS_LIBRARY_RELEASE=D:/vcpkg/installed/x64-windows/debug/lib/geos.lib
```

This is minimal patch that works around the problem.

Next, complete fix should be submitted to GEOS upstream,
preferably using exported targets.
@ras0219-msft ras0219-msft merged commit 793019b into microsoft:master May 1, 2018
@ras0219-msft
Copy link
Contributor

Thanks for the PR!

I also fixed up the references for libspatialite's static build.

@mloskot mloskot deleted the ml/geos-debug-use-postfix-d branch May 4, 2018 19:58
@mloskot
Copy link
Contributor Author

mloskot commented May 4, 2018

@ras0219-msft Thank you!

@dg0yt
Copy link
Contributor

dg0yt commented May 16, 2021

2 years later...

Now I would like to know which direction to take, starting from #17616, and aiming at fixing geos for Unix (#9068).
Is it acceptable to revert this change? I'm aware of other ports which use port geos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants