-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[michaelmiller-sec21] Add new library #37868
Conversation
@microsoft-github-policy-service agree |
Tested usage successfully by
|
I'm a bit nervous to add this given that the name has no search hits anywhere. As you are upstream, do you have customers who are specifically looking to include this in vcpkg's registry? Would you accept naming the port |
@JavierMatosD @ras0219-msft @data-queue and I agree we want this prefixed. If you have issues with this also consider making a private registry: https://learn.microsoft.com/vcpkg/produce/publish-to-a-git-registry |
I'm aware that the library is not widely used. However, there are already a few users. One of them is an small startup that has realized its dependency management with vcpkg. In case of simplification it would be nice if all dependencies worked via one mechanism.
Of course I would. Does this mean that I can install the library via vcpkg install michaelmiller-sec21 ? |
Yes it does :) Note: we (vcpkg) place your PR in draft to give you an opportunity to reply and mark "ready for review". The rationale is that you don't have the ability to add or remove tags in the PR. When you mark "ready for review" we become aware and are able to continue reviewing your PR. If you don't mark "ready for review" we may take a bit longer to notice you've responded. All that to say, please mark this PR "ready for review" once you've applied the recommended changes or responded in one way or another. |
That would also be fine.
Thanks for the clarification. What still needs to be done so that we can successfully complete the pull request? |
We need to change the name of the new port |
Thanks for the new port! |
Thanks to everyone for the cooperation! |
If this PR adds a new port, please uncomment and fill out this checklist:
find_package
calls are REQUIRED, are satisfied byvcpkg.json
's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.vcpkg.json
matches what upstream says.vcpkg.json
matches what upstream says../vcpkg x-add-version --all
and committing the result.