Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[michaelmiller-sec21] Add new library #37868

Merged
merged 5 commits into from
Jun 13, 2024

Conversation

MichaelMiller-
Copy link
Contributor

If this PR adds a new port, please uncomment and fill out this checklist:

  • Changes comply with the maintainer guide.
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@MichaelMiller-
Copy link
Contributor Author

@microsoft-github-policy-service agree

@JonLiu1993 JonLiu1993 self-assigned this Apr 1, 2024
@JonLiu1993 JonLiu1993 changed the title New lib sec21 [sec21] Add new lib sec21 Apr 1, 2024
@JonLiu1993 JonLiu1993 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Apr 1, 2024
@JonLiu1993
Copy link
Member

Tested usage successfully by sec21:x64-windows:

sec21 provides CMake targets:

find_package(sec21 CONFIG REQUIRED)
target_link_libraries(main PRIVATE sec21::sec21)

@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Apr 1, 2024
@BillyONeal
Copy link
Member

I'm a bit nervous to add this given that the name has no search hits anywhere. As you are upstream, do you have customers who are specifically looking to include this in vcpkg's registry?

Would you accept naming the port michaelmiller-sec21?

@BillyONeal BillyONeal added requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. and removed info:reviewed Pull Request changes follow basic guidelines labels Apr 1, 2024
@BillyONeal
Copy link
Member

@JavierMatosD @ras0219-msft @data-queue and I agree we want this prefixed. If you have issues with this also consider making a private registry: https://learn.microsoft.com/vcpkg/produce/publish-to-a-git-registry

@BillyONeal BillyONeal removed the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label Apr 4, 2024
@BillyONeal BillyONeal marked this pull request as draft April 4, 2024 22:02
@MichaelMiller-
Copy link
Contributor Author

MichaelMiller- commented Apr 5, 2024

I'm a bit nervous to add this given that the name has no search hits anywhere. As you are upstream, do you have customers who are specifically looking to include this in vcpkg's registry?

I'm aware that the library is not widely used. However, there are already a few users. One of them is an small startup that has realized its dependency management with vcpkg. In case of simplification it would be nice if all dependencies worked via one mechanism.

Would you accept naming the port michaelmiller-sec21?

Of course I would. Does this mean that I can install the library via

vcpkg install michaelmiller-sec21

?

@JavierMatosD
Copy link
Contributor

JavierMatosD commented May 1, 2024

Of course I would. Does this mean that I can install the library via

vcpkg install michaelmiller-sec21

?

Yes it does :)

Note: we (vcpkg) place your PR in draft to give you an opportunity to reply and mark "ready for review". The rationale is that you don't have the ability to add or remove tags in the PR. When you mark "ready for review" we become aware and are able to continue reviewing your PR. If you don't mark "ready for review" we may take a bit longer to notice you've responded. All that to say, please mark this PR "ready for review" once you've applied the recommended changes or responded in one way or another.

@MichaelMiller-
Copy link
Contributor Author

Yes it does :)

That would also be fine.

Note: we (vcpkg) place your PR in draft to give you an opportunity to reply and mark "ready for review". The rationale is that you don't have the ability to add or remove tags in the PR. When you mark "ready for review" we become aware and are able to continue reviewing your PR. If you don't mark "ready for review" we may take a bit longer to notice you've responded. All that to say, please mark this PR "ready for review" once you've applied the recommended changes or responded in one way or another.

Thanks for the clarification.

What still needs to be done so that we can successfully complete the pull request?

@MichaelMiller- MichaelMiller- marked this pull request as ready for review May 28, 2024 04:59
@JonLiu1993
Copy link
Member

We need to change the name of the new port michaelmiller-sec21.

@BillyONeal BillyONeal changed the title [sec21] Add new lib sec21 [michaelmiller-sec21] Add new library Jun 12, 2024
@BillyONeal BillyONeal added the info:reviewed Pull Request changes follow basic guidelines label Jun 12, 2024
@BillyONeal BillyONeal merged commit e9a5d41 into microsoft:master Jun 13, 2024
17 checks passed
@BillyONeal
Copy link
Member

Thanks for the new port!

@MichaelMiller-
Copy link
Contributor Author

Thanks to everyone for the cooperation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants