-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[godot-cpp] Create a new port #37931
Conversation
@microsoft-github-policy-service agree |
|
I'm not entirely sure how to go about this since the python package provided by vcpkg is now broken due to it's dependency on liblzma. |
I think using |
Since the upstream does not provide exports, please use the |
d1b29c5
to
8280c29
Compare
Port Requested in #34492 ? |
Usage test passed with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll place the PR in draft. Please mark "ready for review" once you've responded so I know.
ports/godot-cpp/0001-Patches-so-that-godot-cpp-is-packagable.patch
Outdated
Show resolved
Hide resolved
ports/godot-cpp/0001-Patches-so-that-godot-cpp-is-packagable.patch
Outdated
Show resolved
Hide resolved
ports/godot-cpp/0001-Patches-so-that-godot-cpp-is-packagable.patch
Outdated
Show resolved
Hide resolved
Upstream has released the latest version 4.2.2: https://github.com/godotengine/godot-cpp/releases/tag/godot-4.2.2-stable, could you please use the latest version? Thank you! |
Fixes #34492
find_package
calls are REQUIRED, are satisfied byvcpkg.json
's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.vcpkg.json
matches what upstream says.vcpkg.json
matches what upstream says../vcpkg x-add-version --all
and committing the result.Notes:
I have made a PR upstream: Make godot-cpp installable with cmake config godotengine/godot-cpp#1418
But in the meanwhile, I have created an unofficial export target
unofficial::godot::cpp
.