Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[freeimage] patch typedef for MacOS #38261

Merged
merged 1 commit into from
May 31, 2024

Conversation

aabellagm
Copy link
Contributor

@aabellagm aabellagm commented Apr 18, 2024

The idea of the PR is to check if OBJC_BOOL_DEFINED is defined to avoid a second redefinition with a different type.

Fixes #38260

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

It conflicts with Objective-C BOOL typedef
@WangWeiLin-MV WangWeiLin-MV self-assigned this Apr 19, 2024
@WangWeiLin-MV WangWeiLin-MV added the category:port-bug The issue is with a library, which is something the port should already support label Apr 19, 2024
@aabellagm
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Mega Limited"

@aabellagm
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Mega Limited (MEGA)"

@aabellagm
Copy link
Contributor Author

Hi @WangWeiLin-MV
Is there something we can do to move this work forward?

@dg0yt
Copy link
Contributor

dg0yt commented May 30, 2024

You must click "Ready for review".

@aabellagm aabellagm marked this pull request as ready for review May 30, 2024 11:34
Copy link
Contributor

@WangWeiLin-MV WangWeiLin-MV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The port usage tests pass with the following triplets:

  • arm64-osx
  • x64-linux
  • x64-osx

@WangWeiLin-MV WangWeiLin-MV added the info:reviewed Pull Request changes follow basic guidelines label May 31, 2024
@vicroms vicroms merged commit 099fb92 into microsoft:master May 31, 2024
16 checks passed
@aabellagm aabellagm deleted the freeimage/fix-typedef-xcode branch May 31, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[freeimage] Usage problem. Typedef redefinition in MacOS
4 participants