-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[qtbase] Fix a few details #38682
[qtbase] Fix a few details #38682
Changes from 27 commits
79d08e4
4bec3d8
7aced28
03215ea
f54f0d3
1918363
2bdb1a0
eaff4f8
9547c97
2fb1516
bba4ed2
ae08c1b
e7f2104
18206b3
750199e
d6f01eb
86334f0
7d59d59
2d20cd8
9aacc92
0c0550a
f9474a4
9d7aa2f
4417ebb
3593ba3
210b592
598db88
043da0a
826de0f
1d94895
0700012
51332d3
74d32cf
8847482
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
{ | ||
"name": "qtbase", | ||
"version": "6.7.0", | ||
"port-version": 1, | ||
"description": "Qt Base (Core, Gui, Widgets, Network, ...)", | ||
"homepage": "https://www.qt.io/", | ||
"license": null, | ||
|
@@ -52,6 +53,10 @@ | |
"default-features": [ | ||
"brotli", | ||
"concurrent", | ||
{ | ||
"name": "cups", | ||
"platform": "osx" | ||
}, | ||
"dbus", | ||
"default-features", | ||
"doubleconversion", | ||
|
@@ -112,9 +117,18 @@ | |
} | ||
] | ||
}, | ||
"cups": { | ||
"description": "Provides support for the Common Unix Printing System.", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If I understand correctly this means the application will be linked with the system provided version of cups, as there is no cups port in vcpkg.git. In Qt 5 I believe cups is only linked into plugins/printsupport/libcupsprintersupport.so and it is probably the same in Qt 6. However, when libcupsprintersupport.so is loaded into the process it brings with it a bunch of shared libraries. On RHEL 9.4 the distribution provided libcups.so pulls in an unpleasant amount of shared libraries:
So a Qt application that dynamically loads the libcups.so.2 plugin will have two versions loaded of several of these libraries - one version from the system and one version from vcpkg. That sounds concerning to me. |
||
"supports": "linux | osx" | ||
}, | ||
"dbus": { | ||
"description": "Qt D-Bus", | ||
"dependencies": [ | ||
{ | ||
"name": "dbus", | ||
"default-features": false, | ||
"platform": "linux" | ||
}, | ||
{ | ||
"name": "qtbase", | ||
"default-features": false, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interfere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On second thought, let's change this the next time, no point blocking over this and triggering a new run.