-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sese] add new port #38704
[sese] add new port #38704
Conversation
@microsoft-github-policy-service agree |
I'm using the add new port function for the first time and it looks like some of the checks are not passing. What should I do?🙃 |
When the async-logger feature is enabled, the following error will occur. |
I fixed the missing symbols when enabling async logger, and finished the generic function to remove empty directories, which all validated on my private registry, so I think it's probably time for a review. |
Compile test pass with following triplets:
|
ports/sese/vcpkg.json
Outdated
"description": "a cross-platform framework", | ||
"homepage": "https://libsese.github.io/sese/", | ||
"license": "Apache-2.0", | ||
"supports": "x64 & (windows | osx | linux) & !uwp & !static", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line makes the port untested in all static triplets, including ALL of linux and osx.
What prevents building a static lib in linux?
A cross-platform framework which can be tested only on one platform doesn't look attractive.
ports/sese/vcpkg.json
Outdated
{ | ||
"name": "sese", | ||
"version": "2.1.1", | ||
"description": "a cross-platform framework", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"description": "a cross-platform framework", | |
"description": "A cross-platform framework", |
Not very descriptive, and the homepage doesn't help at all due to language barriers.
@dg0yt Thanks for your reviews.
|
IANAL but I don't think this is a valid point here. I don't even want to go into details. If users are unsure, they must contact a lawyer.
No. Your exported cmake config must call You announce cross-platform and vcpkg support so this should really be fixed. If someone adds reverse dependencies on sese to vcpkg, you want it to be tested on all supported triplets. |
Hi @SHIINASAMA We are considering new acceptance criteria for ports in the vcpkg registry. Given that this is a new library with no pre-existing user base and it’s not part of a well stablished suite of libraries, we believe that it is a good candidate for self-hosting in a custom registry. Users will still be able to install your library with vcpkg using either the registries or overlay ports features; and you get full control of when you update the port and the changes it includes. Would you be interested in setting up a custom registry for your library? We can aid setting up your registry and providing instructions for your users to install your vcpkg port. We are also interested in receiving feedback regarding the suggested alternative if you decide to give it a try. I'm leaving this PR as a draft to serve as a way of communication with you regarding the suggested alternative of self-hosting this port. Feel free to use this thread to request assistance with said task. |
I see that you already provide instructions to install your package via a registry. You could expand your instructions for users that prefer to install your packages via overlay ports.
git clone https://github.com/libsese/vcpkg-registry
$env:VCPKG_OVERLAY_PORTS=C:/path/to/libsese-vcpkg-registry/ports;$env:VCPKG_OVERLAY_PORTS"
vcpkg install sese |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We decided to reverse our new port acceptance criteria policy. Please address the PR comments so we can accept this port into the vcpkg registry.
ports/sese/vcpkg.json
Outdated
"features": [ | ||
"openssl" | ||
], | ||
"version>=": "1.29.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove all version>=
constraints from the manifest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related fields have been removed
update `2.1.1` to `2.1.2`
find_package
calls are REQUIRED, are satisfied byvcpkg.json
's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.vcpkg.json
matches what upstream says.vcpkg.json
matches what upstream says../vcpkg x-add-version --all
and committing the result.