-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor updates to comments for some verbiage that gets flagged by political correctness tools #38719
Minor updates to comments for some verbiage that gets flagged by political correctness tools #38719
Conversation
Just modify the comments, so I canceled the CI pipeline run. |
Not ready for merge.
Bad idea. CI would catch the missing port version bump for qtbase which the reviewer didn't notice. |
And please don't delay the other qtbase PRs over it! |
The qtbase change was cherry-picked into #38682. |
Note: I will be converting your PR to draft status. The above suggested changes are only recommendations. If you are willing to adopt them, please click "ready for review" after making the modifications. If you do not wish to make any changes, please click "ready for review" directly. That way, I can be aware that you've responded since you can't modify the tags. |
Co-authored-by: Lily Wang <[email protected]>
Thanks (I was out for a bit, so coming back here very late)! |
I cancelled this because it was going to take machine-days of time and invalidate all vcpkg customers' caches, and I don't think that's worth it to fix a comment. However, next time vcpkg_configure_make needs to be changed for any other reason I think this should be included into it. |
I merged this because I just merged another change which invalidated basically all caches. I didn't retrigger the effective world rebuild from it because it only changes a comment. |
Replaces two terms used in comments with some more politically correct alternatives.