Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[azure-iot-sdk-c] Add use-prov-client feature to enable device provisioning client #38841

Merged
merged 3 commits into from
Jun 12, 2024

Conversation

denis2glez
Copy link
Contributor

@denis2glez denis2glez commented May 21, 2024

The use-prov-client feature in the vcpkg.json manifest file was removed in PR #29046, probably by mistake when removing the public-preview feature, and therefore it is not possible to enable the device provisioning client.

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@denis2glez
Copy link
Contributor Author

@denis2glez please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

@denis2glez
Copy link
Contributor Author

I just found that it was intentionally removed in 2f40239. @JoseSanchez7 could you please give any feedback on this?
Thanks

@MonicaLiu0311 MonicaLiu0311 self-assigned this May 22, 2024
@MonicaLiu0311 MonicaLiu0311 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label May 22, 2024
@denis2glez
Copy link
Contributor Author

For future reference, these changes are working without any issues.

@BillyONeal
Copy link
Member

The feature was explicitly removed in #29046 ; I'm guessing @JoseSanchez7 intended to remove only the public-preview feature and accidentally removed this one.

@BillyONeal BillyONeal merged commit 6374fcd into microsoft:master Jun 12, 2024
17 checks passed
@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants