-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pixman] Fix x86 builds not using MSVC #38851
Conversation
There are two situations when modifying files under
Please read the documentation: maintainer guide#versioning. |
endif() | ||
if(VCPKG_DETECTED_CMAKE_CXX_COMPILER_ID STREQUAL "MSVC") | ||
set(VCPKG_CXX_FLAGS "/arch:SSE2 ${VCPKG_CXX_FLAGS}") | ||
endif() | ||
list(APPEND OPTIONS | ||
-Dmmx=enabled | ||
-Dsse2=enabled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if this isn't enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently the missing flag breaks the build, so I can remove the CFLAGS on my next attempt and we can see if the CI runs through.
At present, the version information of your commit is inconsistent with your local one:
Please run
|
Note: I will be converting your PR to draft status. When you're ready, please revert to "ready for review". |
@microsoft-github-policy-service agree company="Flole" |
Fixes the
#Todo
comment in pixman's portfile.cmale