-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mp3lame] Fix MinGW-w64 compatibility #38995
Conversation
Fixes https://sourceforge.net/p/lame/bugs/487/ Patch copied from Robert Hegemann's upstream patches: https://sourceforge.net/p/lame/svn/6410/ https://sourceforge.net/p/lame/svn/6416/
@microsoft-github-policy-service agree |
When running ./vcpkg install mp3lame:x64-mingw-dynamic I receive this following post-build check problem:
Not sure if this is an issue or not, but just thought I'd mention it. |
Not an issue with mingw. FTR there msys2 toolchains which use ucrt.
This is normal. No DLLs to be checked. |
@dg0yt So you know what is causing the issue? Is there any way I could fix it, and should that fix be included in this PR? |
This also fixed the android builds. |
…39096) ``` PASSING, REMOVE FROM FAIL LIST: mp3lame:arm-neon-android PASSING, REMOVE FROM FAIL LIST: mp3lame:x64-android PASSING, REMOVE FROM FAIL LIST: mp3lame:arm64-android ``` Passing on https://dev.azure.com/vcpkg/public/_build/results?buildId=103545&view=results. Fixed by PR #38995. Add `supports: !android` for `coin`. - [x] Changes comply with the [maintainer guide](https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/contributing/maintainer-guide.md). - [ ] ~~SHA512s are updated for each updated download.~~ - [ ] ~~The "supports" clause reflects platforms that may be fixed by this new version.~~ - [ ] ~~Any fixed [CI baseline](https://github.com/microsoft/vcpkg/blob/master/scripts/ci.baseline.txt) entries are removed from that file.~~ - [ ] ~~Any patches that are no longer applied are deleted from the port's directory.~~ - [x] The version database is fixed by rerunning `./vcpkg x-add-version --all` and committing the result. - [x] Only one version is added to each modified port's versions file. --------- Co-authored-by: Lily Wang <[email protected]>
Fixes https://sourceforge.net/p/lame/bugs/487/, allowing mp3lame to be built using the MinGW community triplets.
Patch copied from Robert Hegemann's upstream patches:
https://sourceforge.net/p/lame/svn/6410/
https://sourceforge.net/p/lame/svn/6416/
./vcpkg x-add-version --all
and committing the result.