Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mp3lame] Fix MinGW-w64 compatibility #38995

Merged
merged 2 commits into from
May 30, 2024

Conversation

messmerd
Copy link
Contributor

@messmerd messmerd commented May 28, 2024

Fixes https://sourceforge.net/p/lame/bugs/487/, allowing mp3lame to be built using the MinGW community triplets.

Patch copied from Robert Hegemann's upstream patches:
https://sourceforge.net/p/lame/svn/6410/
https://sourceforge.net/p/lame/svn/6416/

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@messmerd
Copy link
Contributor Author

@microsoft-github-policy-service agree

@messmerd
Copy link
Contributor Author

When running

./vcpkg install mp3lame:x64-mingw-dynamic

I receive this following post-build check problem:

-- Performing post-build validation
warning: Detected outdated dynamic CRT in the following files:
/home/dalton/Documents/mp3lame_vcpkg_patch/vcpkg_messmerd/packages/mp3lame_x64-mingw-dynamic/debug/bin/libmp3lame-0.dll:msvcrt.dll
/home/dalton/Documents/mp3lame_vcpkg_patch/vcpkg_messmerd/packages/mp3lame_x64-mingw-dynamic/bin/libmp3lame-0.dll:msvcrt.dll
To inspect the dll files, use:
dumpbin.exe /dependents mylibfile.dll
error: Found 1 post-build check problem(s). To submit these ports to curated catalogs, please first correct the portfile: /home/dalton/Documents/mp3lame_vcpkg_patch/vcpkg_messmerd/ports/mp3lame/portfile.cmake
Stored binaries in 1 destinations in 238 ms.
Elapsed time to handle mp3lame:x64-mingw-dynamic: 42 s
mp3lame:x64-mingw-dynamic package ABI: 94bae512f3919c6ea6ba0cea16009eccd7c05b1eb519f0a9d71fcfb89ee95e05

Not sure if this is an issue or not, but just thought I'd mention it.
The problem does not occur for the x64-mingw-static triplet.

@Cheney-W Cheney-W added the category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. label May 29, 2024
@dg0yt
Copy link
Contributor

dg0yt commented May 29, 2024

Not sure if this is an issue or not, but just thought I'd mention it.

Not an issue with mingw. FTR there msys2 toolchains which use ucrt.

The problem does not occur for the x64-mingw-static triplet.

This is normal. No DLLs to be checked.

@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label May 29, 2024
@messmerd
Copy link
Contributor Author

@dg0yt So you know what is causing the issue? Is there any way I could fix it, and should that fix be included in this PR?

@vicroms vicroms merged commit 9dc9360 into microsoft:master May 30, 2024
17 checks passed
@messmerd messmerd deleted the fix-mp3lame-mingw-w64 branch May 31, 2024 03:52
@dg0yt
Copy link
Contributor

dg0yt commented Jun 1, 2024

This also fixed the android builds.

vicroms pushed a commit that referenced this pull request Jun 4, 2024
…39096)

```
PASSING, REMOVE FROM FAIL LIST: mp3lame:arm-neon-android
PASSING, REMOVE FROM FAIL LIST: mp3lame:x64-android
PASSING, REMOVE FROM FAIL LIST: mp3lame:arm64-android
```
Passing on
https://dev.azure.com/vcpkg/public/_build/results?buildId=103545&view=results.
Fixed by PR #38995.

Add `supports: !android` for `coin`.
- [x] Changes comply with the [maintainer
guide](https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/contributing/maintainer-guide.md).
- [ ] ~~SHA512s are updated for each updated download.~~
- [ ] ~~The "supports" clause reflects platforms that may be fixed by
this new version.~~
- [ ] ~~Any fixed [CI
baseline](https://github.com/microsoft/vcpkg/blob/master/scripts/ci.baseline.txt)
entries are removed from that file.~~
- [ ] ~~Any patches that are no longer applied are deleted from the
port's directory.~~
- [x] The version database is fixed by rerunning `./vcpkg x-add-version
--all` and committing the result.
- [x] Only one version is added to each modified port's versions file.

---------

Co-authored-by: Lily Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants