Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable additional authentication mechanisms in librdkafka #39184

Merged
merged 4 commits into from
Jun 12, 2024

Conversation

rockwood-openai
Copy link
Contributor

@rockwood-openai rockwood-openai commented Jun 7, 2024

The main reasons from what I can tell for enabling SSL or CURL is to also be able to enabled additional authentication mechanisms

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@rockwood-openai
Copy link
Contributor Author

@microsoft-github-policy-service agree company="OpenAI"

@BillyONeal
Copy link
Member

The title says 'add additional dependencies' but I don't see any dependency changes here. Did you forget to commit vcpkg.json changes?

@@ -1,7 +1,7 @@
{
"versions": [
{
"git-tree": "a84ea0202e606993c8377b34bdbea3c84e08d792",
"git-tree": "f707b3b9aa6cade0699134559081a6df068a7643",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Existing versions must not be changed. Please revert changes to this file, set port-version in vcpkg.json to 1, and rerun vcpkg x-add-version. (There should only be a new version here added to the top, not overwriting an existing version)

@BillyONeal BillyONeal marked this pull request as draft June 11, 2024 00:04
@BillyONeal
Copy link
Member

Please feel free to mark 'ready for review' when you're ready for another review :)

@jimwang118 jimwang118 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Jun 11, 2024
@rockwood-openai rockwood-openai changed the title Add additional auth dependencies to librdkafka Enable additional authentication mechanisms in librdkafka Jun 12, 2024
@rockwood-openai
Copy link
Contributor Author

The title says 'add additional dependencies' but I don't see any dependency changes here. Did you forget to commit vcpkg.json changes?

I mean it adds the additional opt-in auth plugins to librdkafka, I've updated the PR title. Thanks!

@rockwood-openai rockwood-openai marked this pull request as ready for review June 12, 2024 17:35
@BillyONeal BillyONeal merged commit 638daad into microsoft:master Jun 12, 2024
17 checks passed
@BillyONeal
Copy link
Member

Thanks for the improvements!

@jimwang118 jimwang118 added the info:reviewed Pull Request changes follow basic guidelines label Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants