-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable additional authentication mechanisms in librdkafka #39184
Conversation
@microsoft-github-policy-service agree company="OpenAI" |
The title says 'add additional dependencies' but I don't see any dependency changes here. Did you forget to commit |
versions/l-/librdkafka.json
Outdated
@@ -1,7 +1,7 @@ | |||
{ | |||
"versions": [ | |||
{ | |||
"git-tree": "a84ea0202e606993c8377b34bdbea3c84e08d792", | |||
"git-tree": "f707b3b9aa6cade0699134559081a6df068a7643", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Existing versions must not be changed. Please revert changes to this file, set port-version
in vcpkg.json
to 1
, and rerun vcpkg x-add-version
. (There should only be a new version here added to the top, not overwriting an existing version)
Please feel free to mark 'ready for review' when you're ready for another review :) |
I mean it adds the additional opt-in auth plugins to librdkafka, I've updated the PR title. Thanks! |
Thanks for the improvements! |
The main reasons from what I can tell for enabling SSL or CURL is to also be able to enabled additional authentication mechanisms
./vcpkg x-add-version --all
and committing the result.