-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mp3lame] decouple executable as 'frontend' non-default feature #39969
[mp3lame] decouple executable as 'frontend' non-default feature #39969
Conversation
7cb0e89
to
5b965b8
Compare
Reading the maintainer guide I'm unsure to be honest whether
|
This comment was marked as resolved.
This comment was marked as resolved.
5b965b8
to
d68190e
Compare
mp3lameAll features are tested successfully in the following triplet:
|
IIUC "frontend" means "the lame exeutable", i.e. an executable program.
Dependencies must be controlled, not autodetected. vcpkg has a ncurses port, so there must be either an explicit dependency, or ncurses support must be reliably disabled. |
…frontend'" This reverts commit d68190e.
Thanks for your comments @dg0yt
I've tweaked the PR accordingly. Just remembered I still need to look into wiring up the feature for non-Windows/MinGW targets which currently use msbuild instead of configure/make. (Done 8041334)
For simplicity I'll look at adding the dependency. (Done ce34cba) |
Main reason for this is that I was seeing a weird issue when trying to cross-compile on my mac for iOS with the
mp3lame
port resolving-lcurses
but then couldn't findcurses.h
when compilingfrontend/console.c
. I couldn't get to the bottom of why this was happening but because I only wantedmp3lame
forffmpeg
I realised I could just disable a frontend feature../vcpkg x-add-version --all
and committing the result.