-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[apr] bump to 1.7.5 and did some imporvements, availible from this version of the library. #40742
Conversation
In apr of 1.7.5 version, the config was introduced. In this commit it is going to be used instead of unofficial one. * fix-configcmake.patch: Removed. * portfile.cmake (patches): Fo not apply removed fix-configcmake.patch. (vcpkg_cmake_config_fixup): Change package name to apr, since it is official and adjust its path.
APR requires APR_BUILD_STATIC and APR_BUILD_SHARED options to be set for configuring the library linkage. After this commit they will be specified correctly and the library will work correctly in static configuration.
In this version it is 'recommend', but the option defaults to the previous to keep the backward compatibly.
Done via command: `.\vcpkg.exe x-add-version apr'.
…h a warning. * portfile.cmake (install): Copy unofficial-apr-config.cmake * unofficial-apr-config.cmake: New config file for unofficial-apr package, that forwards to apr package and writes a warning.
…t links with original to redirect unofficial::apr to apr packages instead of aliases.
Check for target existing instead of using VCPKG_LIBRARY_LINKAGE variable for creation 'alias' targets.
@rinrab, Thanks for your pr, when I tested the usage by
CMakeLists.txt:
|
This library has non-standard targets. By default, APR builds both static and shared configurations. The target names and library artifacts are So, when you install the library for the If you remove linking against |
Tested usage successfully by
|
Ouch. Why does this form of testing and feedback never stop? Like all ports with varying exported target names, this port should get a |
Opened another pull-request with adding the correct usage. |
Bump the library to version 1.7.5 and did some imporvements, availible from this version of the library.