Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rmlui] Add feature for SVG rendering using lunasvg #40748

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

dbartussek
Copy link
Contributor

@dbartussek dbartussek commented Aug 31, 2024

When rmlui was first added to vcpkg, the lunasvg library necessary for SVG rendering support was not yet available in vcpkg. Since lunasvg is now in vcpkg, I've added a feature flag to build rmlui with SVG support.

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@dbartussek
Copy link
Contributor Author

@microsoft-github-policy-service agree

@Cheney-W Cheney-W added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Sep 2, 2024
@Cheney-W
Copy link
Contributor

Cheney-W commented Sep 2, 2024

Feature test passed with x64-windows triplet.

@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Sep 2, 2024
@vicroms vicroms merged commit 136c521 into microsoft:master Sep 3, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants