Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ruckig] Add new port #41286

Merged
merged 4 commits into from
Oct 2, 2024
Merged

[ruckig] Add new port #41286

merged 4 commits into from
Oct 2, 2024

Conversation

Olli1080
Copy link
Contributor

@Olli1080 Olli1080 commented Oct 1, 2024

  • Changes comply with the maintainer guide.
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

-DBUILD_CLOUD_CLIENT=OFF
-DBUILD_TESTS=OFF
-DBUILD_EXAMPLES=OFF
-DBUILD_SHARED_LIBS=${VCPKG_LIBRARY_LINKAGE}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
-DBUILD_SHARED_LIBS=${VCPKG_LIBRARY_LINKAGE}

Handled by vcpkg_cmake_configure.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review.
Wasn't sure to leave it out since upstream sets it explicitly:
https://github.com/pantor/ruckig/blob/0c467ad654224a648ab85697ed1f87078e25607c/CMakeLists.txt#L15

Comment on lines 19 to 21
vcpkg_cmake_config_fixup(
CONFIG_PATH "lib/cmake/ruckig"
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit-pick

Suggested change
vcpkg_cmake_config_fixup(
CONFIG_PATH "lib/cmake/ruckig"
)
vcpkg_cmake_config_fixup(CONFIG_PATH "lib/cmake/ruckig")

@JavierMatosD JavierMatosD merged commit afbce3a into microsoft:master Oct 2, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants