Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tmx] update to 1.10.0 #41942

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

erikyuzwa
Copy link

@erikyuzwa erikyuzwa commented Nov 4, 2024

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@erikyuzwa erikyuzwa changed the title added support for tmx version 1.10.0 [tmx] added support for version 1.10.0 Nov 4, 2024
@erikyuzwa erikyuzwa changed the title [tmx] added support for version 1.10.0 [tmx] update to 1.10.0 Nov 4, 2024
@FrankXie05 FrankXie05 added the category:port-update The issue is with a library, which is requesting update new revision label Nov 4, 2024
@erikyuzwa
Copy link
Author

planning to update the SHA512 in the portfile.cmake for this lib, but not sure how lol. Still digging 🕳️

@erikyuzwa
Copy link
Author

erikyuzwa commented Nov 4, 2024 via email

@erikyuzwa
Copy link
Author

erikyuzwa commented Nov 4, 2024

I don't get the sha512 thing. I've done the following:

wget https://github.com/baylej/tmx/archive/tmx_1.10.0.tar.gz
vcpkg hash tmx_1.10.0.tar.gz
# returns the following output
302e55c6d78947dbac1470855331fb238e2ac681f10414aef1e3dad5c1128b66aeb2fef0c4cb2d03360b5e5b327e46c9e5d7dc5bf15d411c9fa3cf7dd4351b4f

It returns what I've committed

Any ideas @FrankXie05 ?

@FrankXie05
Copy link
Contributor

@erikyuzwa
For updating the port, you need to submit two commits.

  1. Manually change the version(vcpkg.json) value to the latest version. Modify the corresponding REF(portfile.cmake), run ./vcpkg install tmx, and a new SHA update will be generated, submit this commit.

  2. After completing the first step, run the command ./vcpkg x-add-version tmx, it will automatically generate versions, submit this commit and push it.

You can refer to https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/produce/update-package-version.md

versions/t-/tmx.json Outdated Show resolved Hide resolved
ports/tmx/portfile.cmake Outdated Show resolved Hide resolved
@FrankXie05
Copy link
Contributor

The current CI status is that your patch is no longer suitable for the latest version, so you just need to re-make the patch.

After the new patch is applied, undo the content you manually added to versions/t-/tmx.json (submit a commit), and run the command ./vcpkg x-add-version tmx, commit, and then push.

@FrankXie05
Copy link
Contributor

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review".
That way, I can be aware that you've responded since you can't modify the tags.

@FrankXie05 FrankXie05 marked this pull request as draft November 5, 2024 02:19
@erikyuzwa
Copy link
Author

thanks so much for all the help and advice @FrankXie05! Playing around with it now 🙏

@erikyuzwa
Copy link
Author

the only way the update worked is by removing the patch all together

@erikyuzwa erikyuzwa marked this pull request as ready for review November 5, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants