Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cpp-pinyin] Add new port #42063

Merged
merged 11 commits into from
Nov 12, 2024
Merged

[cpp-pinyin] Add new port #42063

merged 11 commits into from
Nov 12, 2024

Conversation

wolfgitpr
Copy link
Contributor

@wolfgitpr wolfgitpr commented Nov 9, 2024

  • Changes comply with the maintainer guide.
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@wolfgitpr
Copy link
Contributor Author

@microsoft-github-policy-service agree

@Mengna-Li Mengna-Li added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Nov 11, 2024
ports/cpp-pinyin/portfile.cmake Outdated Show resolved Hide resolved
ports/cpp-pinyin/usage Outdated Show resolved Hide resolved
@Mengna-Li Mengna-Li added the info:reviewed Pull Request changes follow basic guidelines label Nov 12, 2024
@vicroms vicroms merged commit acdbbba into microsoft:master Nov 12, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants