Removed unused template function. #9287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If it builds for all platforms, it LGTM. |
dan-shaw
added
info:reviewed
|
It's my first time working with Azure Piplelines. I checked build and runtime manually on Win 10 a Ubunu19. Found no issues. |
|
/azp run |
|
I see that the pipeline was restated for the pr and now windows job is ok. osx job seems not to be running for any of the active PRs... |
JackBoosY
approved these changes
Dec 16, 2019
|
Thanks for the PR! |
strega-nil
pushed a commit
to strega-nil/vcpkg
that referenced
this pull request
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
I'm using vcpkg repo to get myself familiar with MSCS 2019 (after moving from Linux dev environment to Windos). Just by chance bumped into this function an got very interested where/how it is used, but unfortunately I failed to find where it is used in the project. Thus I removed it, recompiled and thought it is worth removing it.